Skip to content

Revert UB fixes #14586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 3 commits into from
Aug 14, 2025
Merged

Revert UB fixes #14586

ktf merged 3 commits into from
Aug 14, 2025

Conversation

@ktf
Copy link
Member

@ktf ktf commented Aug 14, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Aug 14, 2025
Closed
@ktf
Copy link
Member Author

ktf commented Aug 14, 2025

As requested by RC, this reverts recent changes which fix 2 UB and prevent using boost::pmr.

As I said in the meeting, I have no guarantee that this will actually work any better than the current tip of the branch.

@ktf ktf enabled auto-merge (rebase) August 14, 2025 19:53
@ktf ktf merged commit 3cafea0 into dev Aug 14, 2025
12 of 13 checks passed
@ktf ktf deleted the revert-ub-fixes branch August 14, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

@wiechula wiechula Awaiting requested review from wiechula wiechula is a code owner

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

@noferini noferini Awaiting requested review from noferini noferini is a code owner

@nstrangm nstrangm Awaiting requested review from nstrangm nstrangm is a code owner

@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner

@costing costing Awaiting requested review from costing costing is a code owner

@Barthelemy Barthelemy Awaiting requested review from Barthelemy Barthelemy is a code owner

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ktf