Skip to content

Conversation

@ddobrigk
Copy link
Contributor

Implements very minor changes to the extremely useful previous work from @f3sch (thanks!!):

  • changes the name of the max Xiu to still propagate to PV from mMinPropR to a more accurate mMaxPropXiu
  • changes defaults such that by default mMaxPropXiu is 5cm
  • makes mMaxPropXiu settable from the command line

The functionality for setting mMaxPropXiu has been tested and seems to be working fine:
Screenshot 2025-07-25 at 11 38 18

@ddobrigk ddobrigk requested a review from a team as a code owner July 25, 2025 13:15
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 1e0a4df at 2025-07-25 17:34:

++ cp /sw/slc9_x86-64/O2/14544-slc9_x86-64-local1/compile_commands.json .
+++ python3 -c 'import json, os; print(os.path.commonprefix([x["file"] for x in json.loads(open("compile_commands.json").read()) if "sw/BUILD" not in x["file"] and "G__" not in x["file"] and x["file"].endswith(".cxx")]))'
++ O2_SRC=/sw/SOURCES/O2/14544-slc9_x86-64/0/
++ [[ -e /sw/SOURCES/O2/14544-slc9_x86-64/0//CMakeLists.txt ]]

Full log here.

@f3sch
Copy link
Collaborator

f3sch commented Jul 25, 2025

lgtm

@ddobrigk
Copy link
Contributor Author

Hi @shahor02 - could we please merge this? It changes nothing in practice (due to backwards-compatible defaults) but adds a settable max XIU for track pre-propagation at AO2D creation time that, following a discussion in the last Physics Board meeting, we should explore for deployment and saving resources. We should also discuss this in one of the next software meetings after further testing and setup with the DPG. Thank you!

@shahor02
Copy link
Collaborator

Hi @ddobrigk, @f3sch

I was not present at the last PB. Just to be sure: this PR effectively makes only tracks with ITS IB contribution allowed to propagate to the PV instead of those with any ITS contribution. Is this what you want?

@ddobrigk
Copy link
Contributor Author

Hi @ddobrigk, @f3sch

I was not present at the last PB. Just to be sure: this PR effectively makes only tracks with ITS IB contribution allowed to propagate to the PV instead of those with any ITS contribution. Is this what you want?

Yes, that's effectively the new default value. The point is that in the vast majority of analyses, ITS IB contributions are required for primary tracks, and thus the track propagation task is used anyways to propagate only tracks with XIU < 5cm as stored in the AO2Ds. With this default value of 5cm, we do at AO2D creation time the majority (>95%) of the track propagation that gets done at analysis time (modulo the small O(1%) tracks used by the svertexer), saving a lot of CPU. Tracks that only have OB contributions are kept where they are in the new default value.

However, the PR also makes this value settable in case there's the desire to do so. Furthermore, the propagate-tracks option is anyway false everywhere right now, so the current behaviour remains unchanged in case nothing is changed in the DPG scripts - which we will take care to do only very carefully.

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for clarifications, @ddobrigk

@shahor02 shahor02 merged commit 9907116 into AliceO2Group:dev Jul 29, 2025
13 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
* Change name of prepropagation config variable

* Makes max xiu to be propagated settable from command line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants