-
Notifications
You must be signed in to change notification settings - Fork 483
Make max Xiu for pre-propagation settable #14544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 1e0a4df at 2025-07-25 17:34: Full log here. |
|
lgtm |
|
Hi @shahor02 - could we please merge this? It changes nothing in practice (due to backwards-compatible defaults) but adds a settable max XIU for track pre-propagation at AO2D creation time that, following a discussion in the last Physics Board meeting, we should explore for deployment and saving resources. We should also discuss this in one of the next software meetings after further testing and setup with the DPG. Thank you! |
Yes, that's effectively the new default value. The point is that in the vast majority of analyses, ITS IB contributions are required for primary tracks, and thus the track propagation task is used anyways to propagate only tracks with XIU < 5cm as stored in the AO2Ds. With this default value of 5cm, we do at AO2D creation time the majority (>95%) of the track propagation that gets done at analysis time (modulo the small O(1%) tracks used by the svertexer), saving a lot of CPU. Tracks that only have OB contributions are kept where they are in the new default value. However, the PR also makes this value settable in case there's the desire to do so. Furthermore, the |
shahor02
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, thanks for clarifications, @ddobrigk
* Change name of prepropagation config variable * Makes max xiu to be propagated settable from command line
Implements very minor changes to the extremely useful previous work from @f3sch (thanks!!):
mMinPropRto a more accuratemMaxPropXiumMaxPropXiuis 5cmmMaxPropXiusettable from the command lineThe functionality for setting mMaxPropXiu has been tested and seems to be working fine:
