Skip to content

Eov for orbitreset #14534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shahor02 merged 3 commits into from
Jul 23, 2025
Merged

Eov for orbitreset #14534

shahor02 merged 3 commits into from
Jul 23, 2025

Conversation

@lietava
Copy link
Contributor

@lietava lietava commented Jul 21, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@lietava lietava marked this pull request as ready for review July 21, 2025 14:52
@lietava lietava requested a review from a team as a code owner July 21, 2025 14:52
shahor02
shahor02 previously approved these changes Jul 21, 2025
View reviewed changes
Detectors/CTP/workflowScalers/src/ctp-ccdb-orbit.cxx Outdated
auto classname = "std::vector<int64_t>";
metadata["adjustableEOV"] = "true";
ret = api.storeAsTFile_impl(&(vect), *ti, ccdbPath, metadata, tmin, tmax);
if (!api.isSnapshotMode() && metadata.find("adjustableEOV") != metadata.end() && metadata.find("default") == metadata.end()) {
Copy link
Collaborator

@shahor02 shahor02 Jul 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, although since you know how you fill the metadata, the checks for metadata.find("adjustableEOV") != metadata.end() && metadata.find("default") == metadata.end() are not really needed.

Copy link
Contributor Author

@lietava lietava Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I removed the check.

@alibuild
Copy link
Collaborator

alibuild commented Jul 22, 2025

Error while checking build/O2/fullCI_slc9 for 48f9b11 at 2025-07-22 12:31:

## sw/BUILD/O2-sim-challenge-test-latest/log
./sim-challenge.logDetected critical problem in logfile svfinder.log
./sim-challenge.logsvfinder.log:[20492:internal-dpl-ccdb-backend]: [12:31:24][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.logsvfinder.log-[20492:internal-dpl-ccdb-backend]: [12:31:24][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-secondary-vertexing-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][ERROR] CCDBDownloader CURL transfer error - Timeout was reached
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][ERROR] CcdbDownloader finished transfer http://alice-ccdb.cern.ch/GLO/Config/GRPECS for 1546300800000 (agent_id: alimetal03.cern.ch-1753180274-k1v2uE) with http code: 0
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][ERROR] File GLO/Config/GRPECS could not be retrieved. No more hosts to try.
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][FATAL] Unable to find CCDB object GLO/Config/GRPECS/1546300800000
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][ERROR] Exception while running: Fatal error. Rethrowing.
./sim-challenge.log[20492:internal-dpl-ccdb-backend]: [12:31:24][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-secondary-vertexing-workflow, device shutting down. Reason: Fatal error
./sim-challenge.log[ERROR] Workflow crashed - PID 20492 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
./sim-challenge.log[ERROR]  - Device internal-dpl-ccdb-backend: pid 20492 (exit 128)
./sim-challenge.log[INFO]    - First error: [12:31:24][FATAL] Unable to find CCDB object GLO/Config/GRPECS/1546300800000
./sim-challenge.log[ERROR] SEVERE: Device internal-dpl-ccdb-backend (20492) had at least one message above severity 7: Unable to find CCDB object GLO/Config/GRPECS/1546300800000
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5010:internal-dpl-clock]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/45}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/46}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/47}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/48}
./digi.log[5039:SimReader]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/49}
./digi.log[5068:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/37}
./digi.log[5068:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/38}
./digi.log[5068:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/40}
./digi.log[5068:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/42}
./digi.log[5068:internal-dpl-ccdb-backend]: [ERROR] Found duplicate input binding with different spec.:collisioncontext {SIM/COLLISIONCONTEXT/43}
[0 more errors; see full log]

Full log here.

@lietava
Copy link
Contributor Author

lietava commented Jul 23, 2025

@shahor02 can it go ?

@shahor02 shahor02 merged commit a69009b into AliceO2Group:dev Jul 23, 2025
13 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@lietava @mhemmer-cern
Eov for orbitreset (AliceO2Group#14534)
e3ab4fb 
* dev:orbitReset EOV

* clang

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lietava @alibuild @shahor02