Skip to content

DPL: out of line metrics related methods #14527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Jul 19, 2025
Merged

DPL: out of line metrics related methods #14527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 3 additions & 57 deletions Framework/Core/include/Framework/DeviceMetricsInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
#ifndef O2_FRAMEWORK_DEVICEMETRICSINFO_H_
#define O2_FRAMEWORK_DEVICEMETRICSINFO_H_

#include "Framework/RuntimeError.h"
#include "Framework/CompilerBuiltins.h"
#include "Framework/Traits.h"
#include <array>
Expand All @@ -21,6 +20,7 @@
#include <span>
#include <string>
#include <vector>
#include <iosfwd>

namespace o2::framework
{
Expand Down Expand Up @@ -191,62 +191,8 @@ struct DeviceMetricsInfoHelpers {
}
}

static void clearMetrics(std::vector<DeviceMetricsInfo>& infos)
{
for (auto& info : infos) {
info.intMetrics.clear();
info.uint64Metrics.clear();
info.stringMetrics.clear(); // We do not keep so many strings as metrics as history is less relevant.
info.floatMetrics.clear();
info.enumMetrics.clear();
info.intTimestamps.clear();
info.uint64Timestamps.clear();
info.floatTimestamps.clear();
info.stringTimestamps.clear();
info.enumTimestamps.clear();
info.max.clear();
info.min.clear();
info.average.clear();
info.minDomain.clear();
info.maxDomain.clear();
info.metricLabels.clear();
info.metricPrefixes.clear();
info.metricLabelsAlphabeticallySortedIdx.clear();
info.metricLabelsPrefixesSortedIdx.clear();
info.metrics.clear();
info.changed.clear();
}
}
static size_t metricsStorageSize(std::span<DeviceMetricsInfo const> infos)
{
// Count the size of the metrics storage
size_t totalSize = 0;
for (auto& info : infos) {
totalSize += info.intMetrics.size() * sizeof(MetricsStorage<int>);
totalSize += info.uint64Metrics.size() * sizeof(MetricsStorage<uint64_t>);
totalSize += info.stringMetrics.size() * sizeof(MetricsStorage<StringMetric>);
totalSize += info.floatMetrics.size() * sizeof(MetricsStorage<float>);
totalSize += info.enumMetrics.size() * sizeof(MetricsStorage<int8_t>);
totalSize += info.intTimestamps.size() * sizeof(TimestampsStorage<int>);
totalSize += info.uint64Timestamps.size() * sizeof(TimestampsStorage<uint64_t>);
totalSize += info.floatTimestamps.size() * sizeof(TimestampsStorage<float>);
totalSize += info.stringTimestamps.size() * sizeof(TimestampsStorage<StringMetric>);
totalSize += info.enumTimestamps.size() * sizeof(TimestampsStorage<int8_t>);
totalSize += info.max.size() * sizeof(float);
totalSize += info.min.size() * sizeof(float);
totalSize += info.average.size() * sizeof(float);
totalSize += info.minDomain.size() * sizeof(size_t);
totalSize += info.maxDomain.size() * sizeof(size_t);
totalSize += info.metricLabels.size() * sizeof(MetricLabel);
totalSize += info.metricPrefixes.size() * sizeof(MetricPrefix);
totalSize += info.metricLabelsAlphabeticallySortedIdx.size() * sizeof(MetricLabelIndex);
totalSize += info.metricLabelsPrefixesSortedIdx.size() * sizeof(MetricPrefixIndex);
totalSize += info.metrics.size() * sizeof(MetricInfo);
totalSize += info.changed.size() * sizeof(bool);
}

return totalSize;
}
static void clearMetrics(std::vector<DeviceMetricsInfo>& infos);
static size_t metricsStorageSize(std::span<DeviceMetricsInfo const> infos);
};

} // namespace o2::framework
Expand Down
58 changes: 58 additions & 0 deletions Framework/Core/src/DeviceMetricsInfo.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,62 @@ std::ostream& operator<<(std::ostream& oss, MetricType const& val)
return oss;
}

void DeviceMetricsInfoHelpers::clearMetrics(std::vector<DeviceMetricsInfo>& infos)
{
for (auto& info : infos) {
info.intMetrics.clear();
info.uint64Metrics.clear();
info.stringMetrics.clear(); // We do not keep so many strings as metrics as history is less relevant.
info.floatMetrics.clear();
info.enumMetrics.clear();
info.intTimestamps.clear();
info.uint64Timestamps.clear();
info.floatTimestamps.clear();
info.stringTimestamps.clear();
info.enumTimestamps.clear();
info.max.clear();
info.min.clear();
info.average.clear();
info.minDomain.clear();
info.maxDomain.clear();
info.metricLabels.clear();
info.metricPrefixes.clear();
info.metricLabelsAlphabeticallySortedIdx.clear();
info.metricLabelsPrefixesSortedIdx.clear();
info.metrics.clear();
info.changed.clear();
}
}

size_t DeviceMetricsInfoHelpers::metricsStorageSize(std::span<DeviceMetricsInfo const> infos)
{
// Count the size of the metrics storage
size_t totalSize = 0;
for (auto& info : infos) {
totalSize += info.intMetrics.size() * sizeof(MetricsStorage<int>);
totalSize += info.uint64Metrics.size() * sizeof(MetricsStorage<uint64_t>);
totalSize += info.stringMetrics.size() * sizeof(MetricsStorage<StringMetric>);
totalSize += info.floatMetrics.size() * sizeof(MetricsStorage<float>);
totalSize += info.enumMetrics.size() * sizeof(MetricsStorage<int8_t>);
totalSize += info.intTimestamps.size() * sizeof(TimestampsStorage<int>);
totalSize += info.uint64Timestamps.size() * sizeof(TimestampsStorage<uint64_t>);
totalSize += info.floatTimestamps.size() * sizeof(TimestampsStorage<float>);
totalSize += info.stringTimestamps.size() * sizeof(TimestampsStorage<StringMetric>);
totalSize += info.enumTimestamps.size() * sizeof(TimestampsStorage<int8_t>);
totalSize += info.max.size() * sizeof(float);
totalSize += info.min.size() * sizeof(float);
totalSize += info.average.size() * sizeof(float);
totalSize += info.minDomain.size() * sizeof(size_t);
totalSize += info.maxDomain.size() * sizeof(size_t);
totalSize += info.metricLabels.size() * sizeof(MetricLabel);
totalSize += info.metricPrefixes.size() * sizeof(MetricPrefix);
totalSize += info.metricLabelsAlphabeticallySortedIdx.size() * sizeof(MetricLabelIndex);
totalSize += info.metricLabelsPrefixesSortedIdx.size() * sizeof(MetricPrefixIndex);
totalSize += info.metrics.size() * sizeof(MetricInfo);
totalSize += info.changed.size() * sizeof(bool);
}

return totalSize;
}

} // namespace o2::framework