Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jul 11, 2025

removes unused code.
The only one I am not sure about is the smoother but then this was never really used, right @mconcas ?

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 3b5aa45 at 2025-07-12 14:09:

## sw/BUILD/84310d851b80ba544e887f584bfbd4311fb46a93-latest/log
/sw/SOURCES/O2/14504-slc9_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/Smoother.h:20:10: fatal error: ITStracking/ROframe.h: No such file or directory
ninja: build stopped: subcommand failed.


## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14504-slc9_x86-64/0/Detectors/ITSMFT/ITS/tracking/include/ITStracking/Smoother.h:20:10: fatal error: ITStracking/ROframe.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for e2b719e at 2025-07-15 08:56:

No log files found

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Jul 18, 2025

@mconcas are you fine merging these changes?

@mconcas
Copy link
Collaborator

mconcas commented Jul 18, 2025

@mconcas are you fine merging these changes?

Yes, but I'd not squash it.

@mconcas mconcas enabled auto-merge (rebase) July 18, 2025 07:27
@f3sch
Copy link
Collaborator Author

f3sch commented Jul 18, 2025

indeed, @shahor02 could you please merge this, but please do not squash.

@mconcas mconcas disabled auto-merge July 18, 2025 08:01
@mconcas mconcas merged commit 5cdac2f into AliceO2Group:dev Jul 18, 2025
12 checks passed
@f3sch
Copy link
Collaborator Author

f3sch commented Jul 18, 2025

ah thanks, sorry did not know you can merge for files you are not code owner of.

@f3sch f3sch deleted the its/cleanup branch July 18, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants