Skip to content

Conversation

@mpuccio
Copy link
Contributor

@mpuccio mpuccio commented Jul 11, 2025

When the data member was inserted, we forgot to add the corresponding dynamic column in the table.

When the data member was inserted, we forgot to add the corresponding dynamic column in the table.
@mpuccio mpuccio requested a review from a team as a code owner July 11, 2025 12:48
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@mpuccio
Copy link
Contributor Author

mpuccio commented Jul 14, 2025

@ddobrigk this makes the number of PID clusters in the TPC more usable, I forgot to add it when I add the field to the data

@ddobrigk
Copy link
Contributor

Hi @mpuccio , thanks, looks good! But I have no approval powers, I fear... Maybe @jgrosseo / @pzhristov / @ktf can approve? Thanks!

@ktf
Copy link
Member

ktf commented Jul 14, 2025

Just to be clear. The branch is there, correct?

@mpuccio
Copy link
Contributor Author

mpuccio commented Jul 14, 2025

Yes, the underlying information TPCNClsFindableMinusPID is there, but we missed the dynamic column to convert it to the "usable" information (the number of clusters used for PID)

@jgrosseo jgrosseo merged commit 5b80bab into AliceO2Group:dev Jul 15, 2025
13 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
When the data member was inserted, we forgot to add the corresponding dynamic column in the table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants