Event mixing: Do not use arrow functions in groupTable #14501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite groupTable() to use the O2 table iterators instead of manually iterating over Apache Arrow chunked columns.
Credits to @mytkom for the idea and most of the implementation.
It gives a 2x speed-up to the creation of a blocked combination policy -- see the results (mean of 5 benchmark runs) in the table below.
This does not affect the running time of creation of a combination generator and generation of combinations.
FYI @mytkom @chefxxx @MykhailoShamrai