Skip to content

Conversation

@ehellbar
Copy link
Collaborator

@ehellbar ehellbar commented Jul 9, 2025

This fixes the topology generation when we have output proxies + devices with sporadic inputs and expendable + non-expendable devices with sporadic inputs.

It includes

  1. fixing typos in signpost strings
  2. in sporadicDataDeps(): removing check for sporadic inputs when b is expendable and a is not
  3. in alwaysDependent(): before returning the default true, check if ancestor has sporadic inputs. If yes, we already changed the order once.

@ehellbar ehellbar requested a review from a team as a code owner July 9, 2025 07:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@ehellbar
Copy link
Collaborator Author

ehellbar commented Jul 9, 2025

@shahor02 I don't think this should break the original fix by @ktf , but if you prefer, you can still test it if you have a local reproducer for the async reco.

@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for a46701d at 2025-07-09 09:24:

## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for 33e9489 at 2025-07-09 10:37:

## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1

Full log here.

@ehellbar
Copy link
Collaborator Author

ehellbar commented Jul 9, 2025

I changed 3., now we check in sporadicDataDeps() if b is an output proxy.

@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for 54c6f79 at 2025-07-09 10:57:

## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1

Full log here.

@ktf
Copy link
Member

ktf commented Jul 9, 2025

This looks ok to me, after discussion with @ehellbar. I am currently on holidays and I have already screwed up something by merging an alidist PR, so I am not sure I have the stamina to merge it without seeing the full_CI test completed for good.

@ehellbar
Copy link
Collaborator Author

ehellbar commented Jul 9, 2025

If it helps, I successfully tested with a FST including output proxies and on STG using my local build :)

@ktf ktf merged commit fe1d400 into AliceO2Group:dev Jul 9, 2025
10 of 11 checks passed
@ktf
Copy link
Member

ktf commented Jul 9, 2025

The change only affects cases with output proxies, so I consider @ehellbar tests sufficient. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants