-
Notifications
You must be signed in to change notification settings - Fork 483
DPL: fixes for dependency checks of devices with sporadic inputs in TopologyPolicy #14493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for a46701d at 2025-07-09 09:24: Full log here. |
|
Error while checking build/O2/fullCI_slc9 for 33e9489 at 2025-07-09 10:37: Full log here. |
|
I changed 3., now we check in |
|
Error while checking build/O2/fullCI_slc9 for 54c6f79 at 2025-07-09 10:57: Full log here. |
|
This looks ok to me, after discussion with @ehellbar. I am currently on holidays and I have already screwed up something by merging an alidist PR, so I am not sure I have the stamina to merge it without seeing the full_CI test completed for good. |
|
If it helps, I successfully tested with a FST including output proxies and on STG using my local build :) |
|
The change only affects cases with output proxies, so I consider @ehellbar tests sufficient. Merging. |
This fixes the topology generation when we have output proxies + devices with sporadic inputs and expendable + non-expendable devices with sporadic inputs.
It includes
sporadicDataDeps(): removing check for sporadic inputs when b is expendable and a is notalwaysDependent(): before returning the default true, check if ancestor has sporadic inputs. If yes, we already changed the order once.