Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jul 9, 2025

@miranov25 after taking to @mpuccio and @hscheid, I realised that the current residuals are biased since they the take the innermost representation of the track while one should take the outermost one to compare to TPC.

@miranov25 after taking to @mpuccio and @hscheid, I realised that the current residuals are biased since they the take the innermost representation of the track while one should take the outermost one to compare to TPC.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review July 9, 2025 06:37
@f3sch f3sch requested a review from a team as a code owner July 9, 2025 06:37
@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for 92dbe1e at 2025-07-09 08:46:

## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1

Full log here.

@miranov25
Copy link
Contributor

Hello @f3sch,

I agree that we should now switch to using ITS-out, and your code modification is a step in the right direction. That said, we should also keep track of the behavioral change — the old code is still valid in principle, and the information it provides is correct, though less precise (MS) and biased (Energy loss)

Have @mpuccio or @hscheid already tested this version? I’ve prepared some skimmed data and plan to use it soon for delta map creation.

In the recent WP4 meeting, I brought up the importance of bookkeeping the compression settings. Specifically, we need to ensure that whenever compression is changed, we can still decompress the data correctly based on the stored metadata.

Unfortunately, the related issue I opened on this topic was already closed — under the assumption that the necessary metadata will be written to the DataFrame (as a dedicated table), rather than into the AO2D metadata structure itself.

Best regards,
Marian

@f3sch
Copy link
Collaborator Author

f3sch commented Jul 11, 2025

@shahor02 I think this can be merged since the other points in the comment cannot be addressed in this PR.

@shahor02 shahor02 merged commit 0d508b3 into dev Jul 11, 2025
14 checks passed
@shahor02 shahor02 deleted the f3sch-patch-2 branch July 11, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants