Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jul 9, 2025

Provide a default ctor and a templated rebind ctor that propagate the ExternalAllocator* so thrust’s rebinding always sees a valid allocator.

This allows to run on cuda again.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review July 9, 2025 06:37
@f3sch f3sch requested review from fprino, mconcas and shahor02 as code owners July 9, 2025 06:37
@alibuild
Copy link
Collaborator

alibuild commented Jul 9, 2025

Error while checking build/O2/fullCI_slc9 for dc5f652 at 2025-07-09 08:44:

## sw/BUILD/4ca51307b106213ce7ad18dea3427170d8d6aafc-latest/log
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:563: libRivetCore_la-Run.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:612: libRivetCore_la-Analysis.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:633: libRivetCore_la-AnalysisHandler.lo] Error 1
/sw/slc9_x86-64/YODA/yoda-2.1.0-6/include/YODA/highfive/H5Object.hpp:13:10: fatal error: H5Ipublic.h: No such file or directory
make[3]: *** [Makefile:619: libRivetCore_la-AnalysisLoader.lo] Error 1
make[2]: *** [Makefile:659: all-recursive] Error 1
make[1]: *** [Makefile:567: all-recursive] Error 1
make: *** [Makefile:578: all-recursive] Error 1

Full log here.

Copy link
Collaborator

@mconcas mconcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@f3sch f3sch enabled auto-merge (rebase) July 10, 2025 08:24
@f3sch f3sch merged commit 6665ddd into AliceO2Group:dev Jul 11, 2025
13 checks passed
@f3sch f3sch deleted the its/gpu_alloc_fix branch July 11, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants