Skip to content

[ITS3] Fix Y position of ITS3 clusters and hits #14483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fgrosa merged 4 commits into from
Jul 8, 2025
Merged

[ITS3] Fix Y position of ITS3 clusters and hits #14483

fgrosa merged 4 commits into from
Jul 8, 2025

Conversation

@fgrosa
Copy link
Collaborator

@fgrosa fgrosa commented Jul 4, 2025

@fgrosa fgrosa requested review from arossi81, f3sch and mconcas as code owners July 4, 2025 15:31
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Jul 4, 2025
Merged
@fgrosa fgrosa changed the title Fix Y position of ITS3 clusters and hits [ITS3] Fix Y position of ITS3 clusters and hits Jul 4, 2025
@fgrosa
Merge pull request #23 from alibuild/alibot-cleanup-14483
23b11a6 
Please consider the following formatting changes to AliceO2Group#14483
@f3sch
Copy link
Collaborator

f3sch commented Jul 5, 2025

@fgrosa looks good, but the CI failure is genuine.

@alibuild
Copy link
Collaborator

alibuild commented Jul 7, 2025

Error while checking build/O2/fullCI_slc9 for b89669a at 2025-07-07 10:07:

## sw/BUILD/O2-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-3/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):


## sw/BUILD/bf37e0781f9bbebc8ca5da98ea375a76a5741ee8-latest/log
CMake Error at /sw/slc9_x86-64/CMake/v3.31.6-3/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):

Full log here.

@fgrosa fgrosa enabled auto-merge (squash) July 7, 2025 20:05
f3sch
f3sch approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@f3sch f3sch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fgrosa fgrosa merged commit 1f08dbe into AliceO2Group:dev Jul 8, 2025
11 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@fgrosa @alibuild @mhemmer-cern
[ITS3] Fix Y position of ITS3 clusters and hits (AliceO2Group#14483)
266914c 
* Fix Y position of ITS3 clusters and hits

* Please consider the following formatting changes

* Fix namespace

---------

Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f3sch f3sch f3sch approved these changes

@arossi81 arossi81 Awaiting requested review from arossi81 arossi81 is a code owner

@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fgrosa @f3sch @alibuild