Skip to content

[EMCAL-567] Fix 1/3 SM numbers #14477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nstrangm merged 1 commit into from
Jul 3, 2025
Merged

[EMCAL-567] Fix 1/3 SM numbers #14477

nstrangm merged 1 commit into from
Jul 3, 2025

Conversation

@jokonig
Copy link
Collaborator

@jokonig jokonig commented Jul 3, 2025

  • SM20 -> SM19. SM20 does not exist

[EMCAL-567] Fix 1/3 SM numbers
8b4fb5e 
- SM20 -> SM19. SM20 does not exist
@jokonig jokonig requested a review from nstrangm as a code owner July 3, 2025 14:00
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

nstrangm
nstrangm approved these changes Jul 3, 2025
View reviewed changes
Copy link
Collaborator

@nstrangm nstrangm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@nstrangm nstrangm enabled auto-merge (squash) July 3, 2025 14:20
@nstrangm nstrangm merged commit 434fb27 into AliceO2Group:dev Jul 3, 2025
12 of 13 checks passed
SchrodingersGhostCat pushed a commit to SchrodingersGhostCat/AliceO2 that referenced this pull request Jul 4, 2025
@jokonig @SchrodingersGhostCat
[EMCAL-567] Fix 1/3 SM numbers (AliceO2Group#14477)
b511015 
- SM20 -> SM19. SM20 does not exist

Co-authored-by: jokonig <jokonig@cern.ch>
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@jokonig @mhemmer-cern
[EMCAL-567] Fix 1/3 SM numbers (AliceO2Group#14477)
9528374 
- SM20 -> SM19. SM20 does not exist

Co-authored-by: jokonig <jokonig@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nstrangm nstrangm nstrangm approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jokonig @nstrangm