DPL: add a poller to check for the metric-feedback channel #14476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
In the AOD reader it might happen that the memory rate limiting prevents proper handling of the messages coming on the metric-feedback channel. This obviates to the issue by adding an explicit poller for such channel. While doing so, I also had to change the rate limiter to account for the extra polling information, to avoid having a busy loop.
Collaborator
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the AOD reader it might happen that the memory rate limiting prevents
proper handling of the messages coming on the metric-feedback channel.
This obviates to the issue by adding an explicit poller for such channel.
While doing so, I also had to change the rate limiter to account for
the extra polling information, to avoid having a busy loop.