Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jul 3, 2025

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review July 3, 2025 08:00
@f3sch f3sch requested a review from shahor02 as a code owner July 3, 2025 08:00
shahor02
shahor02 previously approved these changes Jul 3, 2025
@f3sch f3sch enabled auto-merge (rebase) July 3, 2025 08:35
@alibuild
Copy link
Collaborator

alibuild commented Jul 3, 2025

Error while checking build/O2/fullCI_slc9 for c3f5788 at 2025-07-03 15:36:

## sw/BUILD/9551d42b0798906bce3078b3bbe522e2c7704f12-latest/log
/sw/SOURCES/O2/14474-slc9_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/Vertex.h:26:10: fatal error: 'format' file not found
ninja: build stopped: subcommand failed.


## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14474-slc9_x86-64/0/DataFormats/Reconstruction/include/ReconstructionDataFormats/Vertex.h:26:10: fatal error: 'format' file not found
ninja: build stopped: subcommand failed.

Full log here.

@shahor02
Copy link
Collaborator

shahor02 commented Jul 3, 2025

@f3sch format header is not found when compiled for GPU, perhaps you would hide this include with #idef guards.

@f3sch
Copy link
Collaborator Author

f3sch commented Jul 3, 2025

Indeed, I did now and test compiled on epn. I saw this in the past that hip libraries don't have <format> and I only tested cuda.

@davidrohr I saw this warning passing by but cannot understand how this is related to this PR, it doesn't seem unrelated though?

2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/BUILD/d210c21a2a53ec15955fa98dc398453f01c747a9/O2/GPU/GPUTracking/Base/hip/hipify/GPUReconstructionHIPExternalProvider.hip:18:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/BUILD/d210c21a2a53ec15955fa98dc398453f01c747a9/O2/GPU/GPUTracking/Base/hip/hipify/GPUReconstructionHIP.h:18:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/GPUTracking/Base/GPUReconstructionDeviceBase.h:20:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/GPUTracking/Global/GPUChain.h:19:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/GPUTracking/Base/GPUReconstructionCPUKernels.h:20:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/GPUTracking/Definitions/GPULogging.h:83:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/Common/GPUCommonLogger.h:62:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/Framework/Logger/include/Framework/Logger.h:14:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/slc9_x86-64/FairLogger/v2.1.0-11/include/fairlogger/Logger.h:27:
2025-07-03@16:42:58:DEBUG:O2:O2:0: In file included from /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/core.h:5:
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/format.h:2478:10: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
2025-07-03@16:42:58:DEBUG:O2:O2:0:  2478 |   return std::isfinite(value);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |          ^~~~~~~~~~~~~~~~~~~~
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/format.h:2475:23: warning: use of infinity is undefined behavior due to the currently enabled floating-point options [-Wnan-infinity-disabled]
2025-07-03@16:42:58:DEBUG:O2:O2:0:  2475 |   constexpr T inf = T(std::numeric_limits<double>::infinity());
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/format.h:3295:16: note: in instantiation of function template specialization 'fmt::detail::isfinite<long double, 0>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:  3295 |   if (!detail::isfinite(value))
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |                ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/format.h:3349:16: note: in instantiation of function template specialization 'fmt::detail::write_float<char, fmt::basic_appender<char>, long double>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:  3349 |              : write_float<Char>(out, value, specs, loc);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |                ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/printf.h:253:13: note: in instantiation of function template specialization 'fmt::detail::write<char, fmt::basic_appender<char>, long double, 0>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:   253 |     detail::write<Char>(this->out, value, this->specs, this->locale);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |             ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/printf.h:288:5: note: in instantiation of function template specialization 'fmt::detail::printf_arg_formatter<char>::write<long double>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:   288 |     write(value);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |     ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/base.h:2500:49: note: in instantiation of function template specialization 'fmt::detail::printf_arg_formatter<char>::operator()<long double, 0>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:  2500 |     case detail::type::long_double_type: return vis(value_.long_double_value);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |                                                 ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/printf.h:562:11: note: in instantiation of function template specialization 'fmt::detail::vprintf<char, fmt::basic_printf_context<char>>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:   562 |   detail::vprintf(buf, fmt, args);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |           ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/fmt/11.1.2-8/include/fmt/printf.h:576:10: note: in instantiation of function template specialization 'fmt::vsprintf<char>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:   576 |   return vsprintf(detail::to_string_view(fmt),
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |          ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/SOURCES/O2/its-gpu_pr3/0/GPU/Common/GPUCommonHelpers.h:49:5: note: in instantiation of function template specialization 'fmt::sprintf<char[33], long, const char *, int, char>' requested here
2025-07-03@16:42:58:DEBUG:O2:O2:0:    49 |     LOGF(error, "GPUCommon Error Code %ld (%s:%d)", (long)error, file, line);
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |     ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/FairLogger/v2.1.0-11/include/fairlogger/Logger.h:400:14: note: expanded from macro 'LOGF'
2025-07-03@16:42:58:DEBUG:O2:O2:0:   400 | #define LOGF FAIR_LOGF
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |              ^
2025-07-03@16:42:58:DEBUG:O2:O2:0: /home/fschlepp/alice/sw/slc9_x86-64/FairLogger/v2.1.0-11/include/fairlogger/Logger.h:437:56: note: expanded from macro 'FAIR_LOGF'
2025-07-03@16:42:58:DEBUG:O2:O2:0:   437 | #define FAIR_LOGF(severity, ...) LOG(severity) << fmt::sprintf(__VA_ARGS__)
2025-07-03@16:42:58:DEBUG:O2:O2:0:       |                                                        ^

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@f3sch f3sch merged commit 8b07c99 into AliceO2Group:dev Jul 4, 2025
11 checks passed
@f3sch f3sch deleted the vtx/print branch July 4, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants