Skip to content

Fix bug in weight filling #14461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgrosseo merged 1 commit into from
Jul 3, 2025
Merged

Fix bug in weight filling #14461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Framework/Core/src/StepTHn.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,15 +441,15 @@ void StepTHn::Fill(int iStep, int nParams, double positionAndWeight[])
if (weight != 1.) {
// initialize with already filled entries (which have been filled with weight == 1), in this case mSumw2 := mValues
if (!mSumw2[iStep]) {
mSumw2[iStep] = createArray();
mSumw2[iStep] = createArray(mValues[iStep]);
LOGF(info, "Created sumw2 container for step %d", iStep);
}
}

// TODO probably slow; add StepTHnT::add ?
mValues[iStep]->SetAt(mValues[iStep]->GetAt(bin) + weight, bin);
if (mSumw2[iStep]) {
mSumw2[iStep]->SetAt(mSumw2[iStep]->GetAt(bin) + weight, bin);
mSumw2[iStep]->SetAt(mSumw2[iStep]->GetAt(bin) + weight * weight, bin);
}
}

Expand Down