Skip to content

CommonUtils: Don't use ROOT TGrid if we build standalone benchmark #14458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidrohr merged 1 commit into from
Jul 2, 2025
Merged

CommonUtils: Don't use ROOT TGrid if we build standalone benchmark #14458

davidrohr merged 1 commit into from
Jul 2, 2025

Conversation

@davidrohr
Copy link
Collaborator

@davidrohr davidrohr commented Jul 1, 2025

No description provided.

@davidrohr davidrohr requested a review from sawenzel as a code owner July 1, 2025 07:57
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Jul 1, 2025

Error while checking build/O2/fullCI_slc9 for f40968c at 2025-07-01 10:51:

## sw/BUILD/O2-latest/log
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/Rtypes.h:47:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TVirtualIsAProxy.h:15:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TVirtualIsAProxy.h:25:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TIsAProxy.h:20:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TString.h:49:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TCollection.h:37:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:81:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:632:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:641:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:655:9: error: no declaration matches 'TClass* MUST_NOT_USE_Rtypes_h::GetClass(Bool_t, Bool_t)'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:80: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:90: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:92: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:80: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:90: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:92: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:35: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:37: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:30: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:43: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:45: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:33: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:43: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:45: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:66: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:76: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:78: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:54: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:64: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:66: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:42: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:52: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:54: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TInterpreter.h:37:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TMethodCall.h:34:7: error: using typedef-name 'TClass' after 'class'
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented Jul 1, 2025

Error while checking build/O2/fullCI_slc9 for b369d45 at 2025-07-01 12:59:

## sw/BUILD/O2-latest/log
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/Rtypes.h:47:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TVirtualIsAProxy.h:15:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TVirtualIsAProxy.h:25:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TIsAProxy.h:20:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TString.h:49:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TCollection.h:37:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:81:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:632:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:641:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:655:9: error: no declaration matches 'TClass* MUST_NOT_USE_Rtypes_h::GetClass(Bool_t, Bool_t)'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:80: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:90: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:663:92: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:80: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:90: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:664:92: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:668:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:669:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:670:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:89: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:99: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TClass.h:671:101: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:22: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:35: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:392:37: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:30: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:43: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:399:45: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:33: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:43: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TBuffer.h:407:45: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:66: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:76: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:207:78: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:54: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:64: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:214:66: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:42: error: 'GetClass' is not a member of 'TClass' {aka 'MUST_NOT_USE_Rtypes_h'}
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:52: error: expected primary-expression before '>' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TDirectory.h:284:54: error: expected primary-expression before ')' token
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TInterpreter.h:37:7: error: using typedef-name 'TClass' after 'class'
/sw/slc9_x86-64/ROOT/v6-32-06-alice8-5/include/TMethodCall.h:34:7: error: using typedef-name 'TClass' after 'class'
[0 more errors; see full log]

Full log here.

@davidrohr davidrohr merged commit 5b28f57 into AliceO2Group:dev Jul 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@davidrohr @alibuild