-
Notifications
You must be signed in to change notification settings - Fork 483
DPL: enable new EoS by default and set data processing and exit transition timeouts #14429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
| defaultInfologgerMode = "infoLoggerD"; | ||
| } else if (deploymentMode == o2::framework::DeploymentMode::OnlineECS) { | ||
| defaultExitTransitionTimeout = "20"; | ||
| defaultExitTransitionTimeout = "15"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we set it shorter on the FLPs? Perhaps I'd do 25/20 here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I understand correctly, for FLP workflows in synchronous processing we'll anyway use the values defined in https://github.com/ehellbar/AliceO2/blob/dev/Framework/Core/src/O2ControlHelpers.cxx#L372 ? Was wondering if we could then skip the declaration here, but then put it to the same values as in the ControlHelpers in case we want to run it locally with DeploymentMode::OnlineECS. So we've been using the 15/10 settings on FLPs in online already for some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed it to 25/20. Indeed, I saw a handful of tasks on the FLPs which are regularly running into the exit transition timeout.
…ition timeouts (#14429) * DPL: set data processing and exit transition timeouts by default to enable new EoS * adjust data processing and exit transition timeouts in O2Control test
…ition timeouts (AliceO2Group#14429) * DPL: set data processing and exit transition timeouts by default to enable new EoS * adjust data processing and exit transition timeouts in O2Control test
…ition timeouts (AliceO2Group#14429) * DPL: set data processing and exit transition timeouts by default to enable new EoS * adjust data processing and exit transition timeouts in O2Control test
No description provided.