Skip to content

Conversation

@ehellbar
Copy link
Collaborator

No description provided.

@ehellbar ehellbar requested a review from a team as a code owner June 20, 2025 12:02
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

defaultInfologgerMode = "infoLoggerD";
} else if (deploymentMode == o2::framework::DeploymentMode::OnlineECS) {
defaultExitTransitionTimeout = "20";
defaultExitTransitionTimeout = "15";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we set it shorter on the FLPs? Perhaps I'd do 25/20 here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I understand correctly, for FLP workflows in synchronous processing we'll anyway use the values defined in https://github.com/ehellbar/AliceO2/blob/dev/Framework/Core/src/O2ControlHelpers.cxx#L372 ? Was wondering if we could then skip the declaration here, but then put it to the same values as in the ControlHelpers in case we want to run it locally with DeploymentMode::OnlineECS. So we've been using the 15/10 settings on FLPs in online already for some time.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed it to 25/20. Indeed, I saw a handful of tasks on the FLPs which are regularly running into the exit transition timeout.

davidrohr
davidrohr previously approved these changes Jun 20, 2025
@ehellbar ehellbar merged commit e1a32f7 into AliceO2Group:dev Jun 24, 2025
11 of 12 checks passed
ehellbar added a commit that referenced this pull request Jun 24, 2025
…ition timeouts (#14429)

* DPL: set data processing and exit transition timeouts by default to enable new EoS

* adjust data processing and exit transition timeouts in O2Control test
matthias-kleiner pushed a commit to matthias-kleiner/AliceO2 that referenced this pull request Aug 6, 2025
…ition timeouts (AliceO2Group#14429)

* DPL: set data processing and exit transition timeouts by default to enable new EoS

* adjust data processing and exit transition timeouts in O2Control test
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
…ition timeouts (AliceO2Group#14429)

* DPL: set data processing and exit transition timeouts by default to enable new EoS

* adjust data processing and exit transition timeouts in O2Control test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants