Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jun 18, 2025

Thou shalt not use namespace in headers.

Thou shalt not use namespace in headers.
@ktf ktf requested review from a team and davidrohr as code owners June 18, 2025 11:12
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@vkucera
Copy link
Collaborator

vkucera commented Jun 18, 2025

Thou shalt not use namespace in headers.

1 gone, 216 to go.

@ktf ktf merged commit 3fa3fe8 into AliceO2Group:dev Jun 18, 2025
11 of 12 checks passed
@ktf
Copy link
Member Author

ktf commented Jun 18, 2025

This one is particularly critical because it breaks ONNXRuntime c API in 1.22.

matthias-kleiner pushed a commit to matthias-kleiner/AliceO2 that referenced this pull request Aug 6, 2025
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants