-
Notifications
You must be signed in to change notification settings - Fork 483
ITS3: move the energy deposition wrt. centre of response #14415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
c178903 to
4079fcb
Compare
4079fcb to
f790fd5
Compare
|
for me its fine, do you want to merge it asap or should we wait until Thursday? |
|
Let’s go over it on Thursday. Thanks @f3sch |
|
we agreed to have this merged, so will undraft |
Head branch was pushed to by a user without write access
|
Error while checking build/O2/fullCI_slc9 for e988e69 at 2025-06-23 13:06: Full log here. |
|
@ChunzhengLab the error is genuine, please add the braces for the double for-loops |
e988e69 to
27aef63
Compare
27aef63 to
029c30b
Compare
fgrosa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove unneeded files, thanks!
Head branch was pushed to by a user without write access
029c30b to
5d41f76
Compare
…p#14415) * move the energy deposition wrt. centre of response * fix the order of IB/OB for noise seeding * print out the resp centre in the CheckChipResponseFile * find the real centre * should use the total eff but not only seed
In principle this shift may improve the deviation of hit position and cluster position.