Skip to content

Conversation

@ChunzhengLab
Copy link
Contributor

In principle this shift may improve the deviation of hit position and cluster position.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch
Copy link
Collaborator

f3sch commented Jun 17, 2025

for me its fine, do you want to merge it asap or should we wait until Thursday?

@ChunzhengLab
Copy link
Contributor Author

Let’s go over it on Thursday. Thanks @f3sch

fgrosa
fgrosa previously approved these changes Jun 17, 2025
@fgrosa fgrosa enabled auto-merge (squash) June 17, 2025 18:30
@ChunzhengLab ChunzhengLab marked this pull request as draft June 17, 2025 18:44
auto-merge was automatically disabled June 17, 2025 18:44

Pull request was converted to draft

@f3sch
Copy link
Collaborator

f3sch commented Jun 19, 2025

we agreed to have this merged, so will undraft

@f3sch f3sch marked this pull request as ready for review June 19, 2025 19:06
f3sch
f3sch previously approved these changes Jun 19, 2025
@f3sch f3sch enabled auto-merge (rebase) June 19, 2025 19:07
auto-merge was automatically disabled June 19, 2025 20:33

Head branch was pushed to by a user without write access

@ChunzhengLab ChunzhengLab dismissed stale reviews from f3sch and fgrosa via e988e69 June 19, 2025 20:33
@ChunzhengLab ChunzhengLab requested a review from a team as a code owner June 19, 2025 20:33
@alibuild
Copy link
Collaborator

alibuild commented Jun 19, 2025

Error while checking build/O2/fullCI_slc9 for e988e69 at 2025-06-23 13:06:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14415-slc9_x86-64/0/Detectors/Upgrades/ITS3/simulation/src/ChipSimResponse.cxx:38:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14415-slc9_x86-64/0/Detectors/Upgrades/ITS3/simulation/src/ChipSimResponse.cxx:39:46: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@f3sch
Copy link
Collaborator

f3sch commented Jun 23, 2025

@ChunzhengLab the error is genuine, please add the braces for the double for-loops

@fgrosa fgrosa enabled auto-merge (squash) June 24, 2025 14:34
Copy link
Collaborator

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unneeded files, thanks!

auto-merge was automatically disabled June 24, 2025 14:37

Head branch was pushed to by a user without write access

@fgrosa fgrosa enabled auto-merge (squash) June 24, 2025 14:38
@fgrosa fgrosa merged commit 41279c2 into AliceO2Group:dev Jun 24, 2025
12 checks passed
@ChunzhengLab ChunzhengLab deleted the chun-fix-depth branch June 25, 2025 20:02
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
…p#14415)

* move the energy deposition wrt. centre of response

* fix the order of IB/OB for noise seeding

* print out the resp centre in the CheckChipResponseFile

* find the real centre

* should use the total eff but not only seed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants