Skip to content

[MID] Improve the macro for the reject list #14411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pillot merged 6 commits into from
Jun 17, 2025
Merged

[MID] Improve the macro for the reject list #14411

pillot merged 6 commits into from
Jun 17, 2025

Conversation

@ariffero
Copy link
Contributor

@ariffero ariffero commented Jun 16, 2025

Allow to put custom timestamps in the json used to build the manual reject list.

Allow custom timestamps
30bb32b 
Allow to put custom timestamps in the json used to build the manual reject list.
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Jun 16, 2025
Merged
@ariffero ariffero changed the title [MID] Improve the macro used to build the reject list [MID] Improve the macro for the reject list Jun 16, 2025
@ariffero
Merge pull request #1 from alibuild/alibot-cleanup-14411
5a28166 
Please consider the following formatting changes to AliceO2Group#14411
@ariffero ariffero marked this pull request as ready for review June 16, 2025 13:44
@ariffero ariffero requested review from a team and shahor02 as code owners June 16, 2025 13:44
@pillot
Copy link
Collaborator

pillot commented Jun 16, 2025

@dstocco can you have a look please?

dstocco
dstocco approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@dstocco dstocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm suggesting some minor changes, but the code looks already good enough, so I already approve it.

@alibuild alibuild mentioned this pull request Jun 16, 2025
Merged
@ariffero
Copy link
Contributor Author

ariffero commented Jun 16, 2025

Thanks @dstocco, I have implemented your suggestions.

@ariffero
Merge pull request #2 from alibuild/alibot-cleanup-14411
d21f903 
Please consider the following formatting changes to AliceO2Group#14411
@pillot pillot merged commit 79f1117 into AliceO2Group:dev Jun 17, 2025
13 checks passed
matthias-kleiner pushed a commit to matthias-kleiner/AliceO2 that referenced this pull request Aug 6, 2025
@ariffero @matthias-kleiner
[MID] Improve the macro for the reject list (AliceO2Group#14411)
cfa8f85 
Allow to put custom timestamps in the json used to build the manual reject list.
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@ariffero @mhemmer-cern
[MID] Improve the macro for the reject list (AliceO2Group#14411)
4d6b91b 
Allow to put custom timestamps in the json used to build the manual reject list.
@ariffero ariffero deleted the my-dev branch November 10, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pillot pillot pillot approved these changes

@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

+1 more reviewer

@dstocco dstocco dstocco approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ariffero @pillot @dstocco @alibuild