Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 12, 2025

This lets us get rid of the code duplication due to the double loops but also restores fully the single threaded performance. Thus I decided to leave single threaded the default.
speedup
ptRatioCN

I would prefer not to squash this.

f3sch added 6 commits June 12, 2025 08:24
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch changed the title Its/pr9 ITS: allow sharing of arena in Tracker & Vertexer Jun 12, 2025
@f3sch f3sch marked this pull request as ready for review June 12, 2025 06:33
@alibuild
Copy link
Collaborator

alibuild commented Jun 13, 2025

Error while checking build/O2/fullCI_slc9 for 92d5d19 at 2025-06-16 07:18:

input queue has size 553
output queue has size 48
input queue has size 514
output queue has size 48
input queue has size 476
output queue has size 48
input queue has size 437
output queue has size 48
input queue has size 425
output queue has size 48
input queue has size 414
output queue has size 48
input queue has size 384
output queue has size 48
input queue has size 348
output queue has size 53
input queue has size 327
output queue has size 53
input queue has size 295
output queue has size 53
input queue has size 266
output queue has size 53
input queue has size 223
output queue has size 53
input queue has size 191
output queue has size 53
input queue has size 153
output queue has size 53
input queue has size 108
output queue has size 63
input queue has size 63
output queue has size 78
input queue has size 25
output queue has size 78
input queue has size 0
output queue has size 78
input queue has size 0
output queue has size 78
input queue has size 0
output queue has size 78
input queue has size 0
output queue has size 78
++ cp thinned_compile_commands.json compile_commands.json
++ CHECKS='-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements'
++ tee error-log.txt
+++ which O2codecheck
+++ find /sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/lib -name crtbegin.o -exec dirname '{}' ';'
++ run_O2CodeChecker.py -j 32 -clang-tidy-binary /sw/slc9_x86-64/o2codechecker/v18.1.2.1-local1/bin/O2codecheck -clang-apply-replacements-binary /sw/slc9_x86-64/Clang/v18.1.8-21/bin-safe/clang-apply-replacements -extra-args=--extra-arg=--gcc-install-dir=/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/lib/gcc/x86_64-unknown-linux-gnu/14.2.0 '-header-filter=.*SOURCES(?!.*/3rdparty/).*' '-checks=-*,modernize-avoid-bind,modernize-deprecated-headers,modernize-make-shared,modernize-raw-string-literal,modernize-redundant-void-arg,modernize-replace-auto-ptr,modernize-replace-random-shuffle,modernize-shrink-to-fit,modernize-unary-static-assert,modernize-use-equals-default,modernize-use-noexcept,modernize-use-nullptr,modernize-use-override,modernize-use-transparent-functors,modernize-use-uncaught-exceptions,readability-braces-around-statements'
No checks enabled.
Unable to run clang-tidy.

Full log here.

@f3sch
Copy link
Collaborator Author

f3sch commented Jun 19, 2025

@mconcas @fprino only when you have time could you take a look?

@mconcas mconcas enabled auto-merge (squash) June 19, 2025 20:14
@mconcas mconcas disabled auto-merge June 20, 2025 05:18
@mconcas mconcas merged commit 52d7d58 into AliceO2Group:dev Jun 20, 2025
12 of 13 checks passed
@f3sch f3sch deleted the its/pr9 branch June 20, 2025 07:18
matthias-kleiner pushed a commit to matthias-kleiner/AliceO2 that referenced this pull request Aug 6, 2025
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants