Skip to content

Conversation

@f3sch
Copy link
Collaborator

@f3sch f3sch commented Jun 11, 2025

  • sets the memory limit to high by default effectively disabling it (also then not printing it as config)
  • use LOG instead of std::cost in TF
  • rework the prepareCluster function a bit to use std more and not double loop
  • also I saw in one test a crash if no tracks were produced, I suspect this was not really a problem and the code handled it before correctly but if no tracks were found we can skip all this entirely anyways

f3sch added 4 commits June 11, 2025 09:42
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@f3sch f3sch marked this pull request as ready for review June 11, 2025 07:50
@mconcas mconcas merged commit b9b561d into AliceO2Group:dev Jun 12, 2025
13 checks passed
@f3sch f3sch deleted the its/pr8 branch June 12, 2025 06:19
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
* ITS: set default mem to high

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

* ITS: fix output crash if zero tracks where found

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

* ITS: tracker fix shadowed variable

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

* ITS: minor adjustments in TF

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>

---------

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants