-
Notifications
You must be signed in to change notification settings - Fork 483
Add compatibility with std::pmr #14379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for 855ea9c at 2025-06-10 15:53: Full log here. |
The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate anymore at runtime on the headers in the stack and move them.
|
@knopers8 @Barthelemy any objections to this? I assume we will never have more than 8 headers to copy... |
|
|
||
| header::Stack extractAdditionalHeaders(const char* inputHeaderStack) | ||
| { | ||
| std::array<header::BaseHeader const*, 5> headers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktf here, you used 5, but the code below supports up to 8. A typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It used to be 5 and I then changed it to 8. Will fix this.
The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate anymore at runtime on the headers in the stack and move them.
The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate
anymore at runtime on the headers in the stack and move them.