Skip to content

Conversation

@ktf
Copy link
Member

@ktf ktf commented Jun 10, 2025

The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate
anymore at runtime on the headers in the stack and move them.

@ktf ktf requested a review from a team as a code owner June 10, 2025 07:45
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 855ea9c at 2025-06-10 15:53:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14379-slc9_x86-64/0/Detectors/TPC/workflow/src/ClusterDecoderRawSpec.cxx:89:20: error: no matching function for call to 'swap(o2::header::Stack&, o2::header::Stack&)'
/sw/slc9_x86-64/GCC-Toolchain/v14.2.0-alice2-1/include/c++/14.2.0/type_traits:138:11: error: no type named 'type' in 'struct std::enable_if<false, void>'
/sw/SOURCES/O2/14379-slc9_x86-64/0/Detectors/TPC/workflow/src/ClusterDecoderRawSpec.cxx:98:18: error: no matching function for call to 'swap(o2::header::Stack&, o2::header::Stack&)'
ninja: build stopped: subcommand failed.

Full log here.

The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate
anymore at runtime on the headers in the stack and move them.
@ktf ktf changed the title Remove references to boost::container::pmr Add compatibility with std::pmr Jun 11, 2025
@ktf
Copy link
Member Author

ktf commented Jun 11, 2025

@knopers8 @Barthelemy any objections to this? I assume we will never have more than 8 headers to copy...

@ktf ktf merged commit ad4cc98 into AliceO2Group:dev Jun 12, 2025
17 of 18 checks passed

header::Stack extractAdditionalHeaders(const char* inputHeaderStack)
{
std::array<header::BaseHeader const*, 5> headers;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktf here, you used 5, but the code below supports up to 8. A typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It used to be 5 and I then changed it to 8. Will fix this.

mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
The move assign operator is deleted is std::pmr::polymorphic_allocator so we cannot iterate
anymore at runtime on the headers in the stack and move them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants