-
Notifications
You must be signed in to change notification settings - Fork 483
ITS-GPU: print params, add stream abstraction and use for trackleting #14290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for b967887 at 2025-05-19 01:45: Full log here. |
|
@f3sch just FYI: Do you have access to the EPN slurm batch system? From there you can get an interactive node and test compilation there. Might be easier than to use the CI. |
|
Hi @davidrohr, yes I do and I am actively using it to test most of the code :) At home I can compile for Nvidia as-well, since I have not figured out how to use the ci containers... yet. |
|
OK, I see. the shm-size and privileged flags are only if you actually want to run O2 inside, for compilation you can skip them. |
prints gpu kernel params Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
uses multiple streams for trackleting Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
|
Ok, I tested this, and I get reasonable results. |
|
This is fine for now. In principle, we could just use the stream arrays of GPU Reconstruction instead of your own set of streams, and we already have an equivalend of yous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is fine to consider the possibility for streams which are independent from GPUReco, just for those cases (e.g. prototyping of ALICE 3 tracking) where we don't need the GPUReconstruction (yet).
I would add the possibility of obtaining the streams from the GPU reconstruction in the case that we actually use it.
However, I agree that this can be done a second time, where we also demonstrate some better performance improvement by using multiple streams.
Do not merge.for now this is just to check if it compiles on hip since I do not have the hardware, sorry for the noise.
This PR prints the gpu params and introduces a general stream abstraction, which is then used in the most low hanging fruit, e.g. the trackleting. I still have to measure if this brings actually any benefit, in any case the number of streams that are used can later be configured via the params.