Skip to content

Conversation

@pzhristov
Copy link
Contributor

Mask the isospin information in the PDG code.
Use nCollND() instead of the deprecated nCollNDTot().

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented May 17, 2025

Error while checking build/O2/fullCI_slc9 for 8910717 at 2025-05-19 01:17:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log
sim.log-[01:17:07][FATAL] Inconsistency in primary particles treated 144 vs expected 145
[ERROR] SHUTTING DOWN DUE TO SIGNALED EXIT IN COMPONENT 5213
[01:17:07][FATAL] Inconsistency in primary particles treated 144 vs expected 145


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/7ec3451143fc2db880202546390c3e002ae60759/slc9_x86-64/o2checkcode/1.0-local33/etc/modulefiles
++ cat
--

Full log here.

@pzhristov
Copy link
Contributor Author

@sawenzel I am not sure why the fullCI fails, the inconsistency between the number of expected and processed primary particles is not related to the changes in the PR.

@sawenzel
Copy link
Collaborator

@pzhristov : The fullCI passes with your mods. Now the question is what will happen when we go to Pythia8314, where the change will be applied again?

@pzhristov
Copy link
Contributor Author

@sawenzel The problem is that we add some "nuclei" with isospin one in the code itself, and I did not see them when checking the external file. I can change the logic and mask only if the isospin is 9.

@pzhristov pzhristov changed the title Preparation for Pythia8314 Preparation for Pythia8315 May 28, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 83d2122 at 2025-05-28 17:42:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14286-slc9_x86-64/0/Generators/src/GeneratorPythia8.cxx:661:39: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 9ea3a70 at 2025-05-29 07:49:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14286-slc9_x86-64/0/Generators/src/GeneratorPythia8.cxx:661:39: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@alibuild
Copy link
Collaborator

alibuild commented May 29, 2025

Error while checking build/O2/fullCI_slc9 for d35f2ca at 2025-06-01 02:10:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile sim.log
sim.log-[02:10:36][FATAL] Inconsistency in primary particles treated 144 vs expected 145
[ERROR] SHUTTING DOWN DUE TO SIGNALED EXIT IN COMPONENT 4060
[02:10:36][FATAL] Inconsistency in primary particles treated 144 vs expected 145


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/edfc5998e178f4d53424d0031904ccb956b650c3/slc9_x86-64/o2checkcode/1.0-local36/etc/modulefiles
++ cat
--

Full log here.

@pzhristov
Copy link
Contributor Author

Since isospin 9 is used to indicate beam remnants, it cannot simply be masked. Additional changes will address this issue.

@pzhristov
Copy link
Contributor Author

@sawenzel @jackal1-66 I confirm that these changes work well with Pythia8.315 and the beam remnants are treated correctly in Geant4 (no exceptions). It is possible that there was a bug in the status code introduced in 8.314 that was fixed later in 8.315, but I did not investigate further. The compilation error on aarch64 is in Monitoring and not related to this PR. If you agree, I will merge it and prepare a PR to bump Pythia8

@sawenzel sawenzel merged commit 364c0bc into AliceO2Group:dev Jun 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants