Skip to content

Out of line FairTBuffer destructor #14265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
May 13, 2025
Merged

Out of line FairTBuffer destructor #14265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Framework/Core/include/Framework/TMessageSerializer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class FairOutputTBuffer : public TBufferFile
: TBufferFile(TBuffer::kWrite, msg.GetSize() - sizeof(char*), embedInItself(msg), false, fairMQrealloc)
{
}

~FairOutputTBuffer() override;
// Helper function to keep track of the FairMQ message that holds the data
// in the data itself. We can use this to make sure the message can be reallocated
// even if we simply have a pointer to the data. Hopefully ROOT will not play dirty
Expand All @@ -60,6 +62,7 @@ class FairInputTBuffer : public TBufferFile
: TBufferFile(TBuffer::kRead, size - sizeof(char*), data + sizeof(char*), false, nullptr)
{
}
~FairInputTBuffer() override;
};

struct TMessageSerializer {
Expand Down
3 changes: 3 additions & 0 deletions Framework/Core/src/TMessageSerializer.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@

using namespace o2::framework;

FairOutputTBuffer::~FairOutputTBuffer() = default;
FairInputTBuffer::~FairInputTBuffer() = default;

void* FairOutputTBuffer::embedInItself(fair::mq::Message& msg)
{
// The first bytes of the message are used to store the pointer to the message itself
Expand Down