Skip to content

DPL: improve logs for new calibration scheme #14030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ktf merged 1 commit into from
Jun 26, 2025
Merged

DPL: improve logs for new calibration scheme #14030

ktf merged 1 commit into from
Jun 26, 2025

Conversation

@ktf
Copy link
Member

@ktf ktf commented Mar 10, 2025

  • Report correct timeout for readers.
  • Improve message when dropping data which is not going to be processed by
    the CalibrationOnly mode.

@ktf ktf requested a review from a team as a code owner March 10, 2025 07:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

davidrohr
davidrohr requested changes Mar 10, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Mar 27, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for 9610896 at 2025-06-25 14:59:

[3703/5748] Linking CXX executable stage/bin/o2-calibration-mch-dcs-sim-workflow
[3704/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2test-emcal-PedestalProcessorData.dir/test/testPedestalProcessorData.cxx.o
[3705/5748] Linking CXX executable stage/bin/o2-calibration-mid-dcs-sim-workflow
[3706/5748] Linking CXX shared library stage/lib64/libO2FV0DCSMonitoring.so
[3707/5748] Building CXX object Detectors/ITSMFT/MFT/condition/CMakeFiles/O2lib-MFTCondition.dir/src/DCSConfigUtils.cxx.o
[3708/5748] Building CXX object Detectors/MUON/MCH/Conditions/CMakeFiles/O2exe-mch-scan-hvlv-ccdb.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3709/5748] Linking CXX shared library stage/lib64/libO2FDDDCSMonitoring.so
[3710/5748] Building CXX object Detectors/MUON/MCH/IO/CMakeFiles/O2exe-mch-statusmaps-reader-workflow.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3711/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/EMCALPedestalHelper.cxx.o
[3712/5748] Linking CXX executable stage/tests/o2-test-ctf-ft0
[3713/5748] Building CXX object Detectors/MUON/MCH/IO/CMakeFiles/O2exe-mch-statusmaps-writer-workflow.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3714/5748] Building CXX object Detectors/FIT/FV0/dcsmonitoring/CMakeFiles/O2exe-fv0-dcs-workflow.dir/workflow/fv0-dcs-data-workflow.cxx.o
[3715/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/EMCDCSProcessor.cxx.o
[3716/5748] Linking CXX executable stage/bin/o2-fv0-dcs-workflow
[3717/5748] Building CXX object Detectors/ITSMFT/MFT/condition/CMakeFiles/O2lib-MFTCondition.dir/src/MFTDCSProcessor.cxx.o
[3718/5748] Generating G__O2FT0DCSMonitoring.cxx, ../../../../stage/lib64/G__O2FT0DCSMonitoring_rdict.pcm, ../../../../stage/lib64/libO2FT0DCSMonitoring.rootmap
[3719/5748] Building CXX object Detectors/FIT/FV0/dcsmonitoring/CMakeFiles/O2exe-fv0-dcs-config-workflow.dir/workflow/fv0-dcs-config-workflow.cxx.o
[3720/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/EMCALTimeCalibData.cxx.o
[3721/5748] Building CXX object Detectors/FIT/FDD/dcsmonitoring/CMakeFiles/O2exe-fdd-dcs-workflow.dir/workflow/fdd-dcs-data-workflow.cxx.o
[3722/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2lib-MCHStatus.dir/src/StatusMapCreatorParam.cxx.o
[3723/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/PedestalProcessorDevice.cxx.o
[3724/5748] Building CXX object Detectors/FIT/FT0/dcsmonitoring/CMakeFiles/O2exe-ft0-dcs-workflow.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3725/5748] Building CXX object Detectors/FIT/FT0/dcsmonitoring/CMakeFiles/O2exe-ft0-dcs-config-workflow.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3726/5748] Building CXX object Detectors/DCS/testWorkflow/CMakeFiles/O2exe-dcs-proxy.dir/src/dcs-proxy.cxx.o
[3727/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2lib-MCHStatus.dir/src/StatusMap.cxx.o
[3728/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2exe-mch-statusmap-creator-workflow.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3729/5748] Building CXX object Detectors/FIT/FDD/dcsmonitoring/CMakeFiles/O2exe-fdd-dcs-config-workflow.dir/workflow/fdd-dcs-config-workflow.cxx.o
[3730/5748] Building CXX object Detectors/ITSMFT/MFT/condition/CMakeFiles/O2lib-MFTCondition.dir/src/DCSConfigReader.cxx.o
[3731/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2exe-mch-statusmap-to-rejectlist.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3732/5748] Linking CXX executable stage/bin/o2-fv0-dcs-config-workflow
[3733/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2lib-MCHStatus.dir/src/HVStatusCreator.cxx.o
[3734/5748] Linking CXX executable stage/bin/o2-fdd-dcs-workflow
[3735/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/EMCALCalibExtractor.cxx.o
[3736/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2test-mch-statusmap.dir/__/__/__/__/Common/Utils/src/fpu.cxx.o
[3737/5748] Building CXX object Detectors/MUON/MCH/Status/CMakeFiles/O2lib-MCHStatus.dir/G__O2MCHStatus.cxx.o
[3738/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2exe-calibration-emcal-pedestal-processor-workflow.dir/testWorkflow/emc-pedestal-processor-workflow.cxx.o
[3739/5748] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/src/ChamberResponseParams.cxx.o
[3740/5748] Linking CXX executable stage/bin/o2-fdd-dcs-config-workflow
[3741/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/PedestalCalibDevice.cxx.o
[3742/5748] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/src/ChamberEfficiencyResponse.cxx.o
[3743/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2lib-EMCALCalibration.dir/src/EMCALChannelData.cxx.o
[3744/5748] Building CXX object Detectors/FIT/FT0/dcsmonitoring/CMakeFiles/O2lib-FT0DCSMonitoring.dir/G__O2FT0DCSMonitoring.cxx.o
[3745/5748] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/src/ClusterLabeler.cxx.o
[3746/5748] Building CXX object Detectors/EMCAL/calibration/CMakeFiles/O2exe-calibration-emcal-pedestal-calib-workflow.dir/testWorkflow/emc-pedestal-calib-workflow.cxx.o
[3747/5748] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/src/ChamberResponse.cxx.o
[3748/5748] Building CXX object Detectors/ITSMFT/MFT/condition/CMakeFiles/O2lib-MFTCondition.dir/G__O2MFTCondition.cxx.o
[3749/5748] Building CXX object Detectors/MUON/MID/Simulation/CMakeFiles/O2lib-MIDSimulation.dir/src/ChamberHV.cxx.o
[3750/5748] Building CXX object Detectors/MUON/MCH/IO/CMakeFiles/O2exe-mch-statusmaps-reader-workflow.dir/src/StatusMapReaderSpec.cxx.o
[3751/5748] Building CXX object Detectors/FIT/FT0/dcsmonitoring/CMakeFiles/O2lib-FT0DCSMonitoring.dir/src/FT0DCSDataProcessor.cxx.o
[3752/5748] Building CXX object Detectors/MUON/MID/Simulation/test/CMakeFiles/O2test-mid-Geometry.dir/__/__/__/__/__/Common/Utils/src/fpu.cxx.o

Full log here.

@davidrohr
Copy link
Collaborator

davidrohr commented Jun 26, 2025

@ktf : What is the status here? Could you address my comments as far as possible, and additional messages we don't have in here yet, we could bring in with a separate PR?

@ktf
DPL: improve logs for new calibration scheme
6da9bd8 
- Report correct timeout for readers.
- Improve message when dropping data which is not going to be processed by
  the CalibrationOnly mode.
@ktf
Copy link
Member Author

ktf commented Jun 26, 2025

I have just updated the with my understanding of your comments.

davidrohr
davidrohr approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@davidrohr davidrohr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, without actually trying, this looks exactly like what I have asked for. Thx!

@ktf ktf merged commit aa1ca7a into AliceO2Group:dev Jun 26, 2025
18 checks passed
mhemmer-cern pushed a commit to mhemmer-cern/AliceO2 that referenced this pull request Sep 9, 2025
@ktf @mhemmer-cern
DPL: improve logs for new calibration scheme (AliceO2Group#14030)
2b1d302 
- Report correct timeout for readers.
- Improve message when dropping data which is not going to be processed by
  the CalibrationOnly mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidrohr davidrohr davidrohr approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ktf @alibuild @davidrohr