Skip to content

Conversation

@makor
Copy link
Contributor

@makor makor commented Jan 31, 2025

Feature still needs to be tested.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

Copy link
Collaborator

@wiechula wiechula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps use directly Point3D as member. You might need to

#include "MathUtils/Cartesian.h"

@makor makor marked this pull request as ready for review February 27, 2025 14:04
@alibuild
Copy link
Collaborator

alibuild commented Mar 1, 2025

Error while checking build/O2/fullCI for 624ec73 at 2025-03-01 13:54:

No log files found

Full log here.

@wiechula wiechula enabled auto-merge (rebase) March 6, 2025 17:13
@wiechula wiechula merged commit 0bd7fb7 into AliceO2Group:dev Mar 6, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants