Dockerize services #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To create Docker Compose stack: ``` make up ``` To remove Docker Compose stack: ``` make down ``` To follow the subsystem logs: ``` make sub ``` To run the ground station cli: ``` make gnd ```
dheadrick1618
requested changes
Jan 29, 2024
Member
dheadrick1618
left a comment
dheadrick1618
left a comment
There was a problem hiding this comment.
Good start. Please add the usage to README. Also please add a contributing README ( see https://github.com/AlbertaSat/ex3_simulated_subsystems/blob/main/Contributing_README.md ) as a reference.
For future branches please follow the standard naming branch naming convention which is mentioned in that 'contributing README'.
Collaborator
Author
|
New changes following branch naming conventions should be in #2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To create Docker Compose stack:
To remove Docker Compose stack:
To follow the subsystem logs:
To run the ground station cli: