forked from Luuxis/minecraft-java-core
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from luuxis:master #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
185
commits into
AkariNext:master
Choose a base branch
from
Luuxis:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves error handling when no Java versions are found by returning an empty path and a clearer message. Refactors Java executable path resolution, especially for macOS, and removes redundant code.
Wrapped reading of the 'bin' file in try-catch blocks to prevent errors if the file does not exist when resolving the Java executable path on macOS. This improves robustness during Java extraction and path setup.
Update package.json and package-lock.json to release version 4.1.4, moving out of beta.
Adds logic to copy the Minecraft jar file to the corresponding version directory after writing the version JSON. This ensures the jar is available alongside the version metadata for Forge, NeoForge, Fabric, Legacy Fabric, and Quilt installations.
Introduces additional boundary checks to prevent buffer overruns when parsing ZIP file structures. Also standardizes error messages to English for unsupported compression methods.
Replaced the previous CC-BY-NC 4.0 license with a custom Luuxis License v1.0 in LICENSE.md and updated license headers in all source files to reference the new license and author attribution. This change clarifies usage, redistribution, and commercial restrictions as defined by the new license.
Update package.json and package-lock.json to version 4.1.5 for minecraft-java-core.
Changed test launcher configuration to use new instance, version, and loader settings. Added error event handler for improved debugging. Minor cleanup in Minecraft-Java.ts.
Changed the launcher configuration to target the Hypixel instance with Minecraft version 1.8.9 and Forge loader. Updated memory allocation and added ignored files and folders to the configuration.
Added a comprehensive Forge maven-metadata.json file to assets. Updated forge loader logic in forge.ts to utilize this metadata. Adjusted package.json and test/index.js to support these changes.
Adds the OAuth2 refresh_token to all error responses in the Microsoft authentication flow, ensuring clients can access the token for recovery or retry scenarios. Also attaches hasGame to the final AuthResponse object.
The hasGame property was removed from the returned profile object in the Microsoft authenticator. This streamlines the response and eliminates an unused field.
Replaces the fetchJSON helper with direct fetch calls and streamlines the authentication process for Xbox Live, XSTS, and Minecraft services. Improves error handling, updates token and profile retrieval logic, and uses crypto.randomUUID for client_token generation. Cleans up redundant code and enhances clarity in the authentication sequence.
Update package.json and package-lock.json to reflect new version 4.1.7.
Replaces account refresh error handling with process exit on error and refactors launcher event listeners to use separate statements for improved readability.
Replaces the previous ESM example with a CommonJS example that demonstrates persistent Microsoft authentication using a local account.json file, token refresh handling, and updated launcher options. The new example provides a more robust and production-ready approach for managing user authentication and launching Minecraft instances.
Bumped package version to 4.2.0 in package.json and package-lock.json. Improved getBase64 utility in Microsoft.ts to handle fetch errors and use arrayBuffer for base64 conversion.
Corrects timestamp calculation for token expiry checks and updates property names for Xbox account mapping. Also ensures the correct expires_in value is used for access token expiration.
Update package.json and package-lock.json to reflect new version 4.2.1.
199d863 to
03b7c03
Compare
Changed the user instance API URL in both README.md and test/index.js to use a new UUID.
Adds a check to set 'java.type' to 'jre' if 'java.version' is present and 'java.type' is not a string. Ensures proper initialization of Java options before starting.
The oauth2 property was removed from the returned profile object in the Microsoft authenticator. This cleans up the response structure and eliminates unnecessary data.
Update package.json and package-lock.json to reflect new version 4.2.2.
Adds a trailing dot to the shortVersion string when filtering versions, ensuring correct matching of version prefixes in the new API approach.
Update package.json and package-lock.json to reflect new version 4.2.3.
Refactored Microsoft authentication to allow specifying a custom redirect_uri, improving flexibility for different OAuth flows. Updated Electron and NW.js GUI modules to accept and use the redirect_uri parameter. Removed the default hardcoded redirect_uri from multiple locations and centralized its configuration in the Microsoft class constructor. Also deleted the .vscode/settings.json file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )