-
Notifications
You must be signed in to change notification settings - Fork 88
Adding benchmarks for Karapace 4 and 5 #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
cd39bc5 to
548080c
Compare
|
Ideally there should be no difference in performance between rest-proxy v4 and v5 as majority of the code changes were for SR, but then rest-proxy uses schema-registry and that implementation changed. |
@nosahama can you may be also run these scripts on your pc for 4 and 5 versions, just to compare? |
548080c to
66aadbb
Compare
66aadbb to
935cdff
Compare
| karapace5,/topics/test-topic-2,121.25092418013082,120.24324999947567,50000 | ||
|
|
||
| Version,Topic,Endpoint,Avg latency (ms),P95 latency (ms),Total messages consumed | ||
| karapace5,test-topic-2,/consumers/json_consumer_group/instances/json_consumer_instance,11162.879458999669,11162.879458999669,50000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path is missing /records.
| % sh run_benchmarks.sh | ||
|
|
||
| 🔹 Benchmarking karapace5 at http://localhost:8082/topics | ||
| Avg: 0.65 ms, P95: 0.67 ms, first response: ["test-topic-11","test-topic-8","test-topic-96","test-topic-59","test-topic-16","test-topic-44","test-topic-32","test-topic-54","test-topic-91","test-topic-1","test-topic-66","test-topic-27","test-top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line seems to be cut off.
|
|
||
| ✅ Results saved to karapace5_benchmarks.csv | ||
| Fetched 50000 messages, total 50000 | ||
| Avg: 11157.99 ms, P95: 11157.99 ms, total messages consumed: 50000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same values for Avg & P95.
About this change - What it does
Under benchmarks dir, we have new scripts which
Added results for karapace 4 and 5 versions.
References: #xxxxx
Why this way