Skip to content

Add health check for apps and a common.mk #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bitterpanda63 merged 11 commits into from
Dec 30, 2025
Merged

Add health check for apps and a common.mk #563

bitterpanda63 merged 11 commits into from
Dec 30, 2025

Conversation

@bitterpanda63
Copy link
Member

@bitterpanda63 bitterpanda63 commented Dec 30, 2025 •
edited by aikido-pr-checks bot
Loading

Summary by Aikido

Security Issues: 0 Quality Issues: 0 Resolved Issues: 0

🚀 New Features

  • Introduced sample-apps/common.mk and get_ports.sh for dynamic ports.

⚡ Enhancements

  • Added health check script and retried workflow step integration.
  • Refactored benchmark workflows to use make health-check and dynamic ports.

🔧 Refactors

  • Updated multiple sample app Makefiles to include common.mk usage.

More info

bitterpanda63 and others added 10 commits December 30, 2025 08:58
@bitterpanda63
Create a health_check.sh script in sample-apps/
1ab2e28
@bitterpanda63 @mistral-vibe
Refactor benchmark workflows to use dynamic ports from Makefiles
f6e46e7 
- Created sample-apps/common.mk with standardized PORT/PORT_DISABLED variables
- Created get_ports.sh script to extract ports from Makefiles dynamically
- Updated flask-mysql, starlette-postgres-uvicorn, and flask-mysql-uwsgi Makefiles to use common.mk
- Modified benchmark workflow to get ports dynamically instead of hardcoding
- Health check now uses the actual ports defined in each app's Makefile
- Each app can override default ports (8086/8087) as needed

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@bitterpanda63 @mistral-vibe
Update more sample apps to use common.mk
97ea45b 
- Updated django-mysql, flask-postgres, django-mysql-gunicorn, flask-mongo
- All now use common.mk for install target and AIKIDO environment variables
- Each app can override default ports as needed
- Consistent pattern across all sample apps

Generated by Mistral Vibe.
Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
@bitterpanda63
Fix up starlette-postgres-uvicorn
0b988e3
@bitterpanda63
Fix up flask-mysql
ce42ff8
@bitterpanda63
Cleanup get_ports.sh mess
595f825
@bitterpanda63
Add a make health-check
378e5bf
@bitterpanda63
Benchmarks check app health with makeifle
6aae6fe
@bitterpanda63
Fixes for sample app makefiles
0f7c7ce
@bitterpanda63
Fix remaining make files to use common.mk
a106b95
hansott
hansott reviewed Dec 30, 2025
View reviewed changes
hansott
hansott reviewed Dec 30, 2025
View reviewed changes
bitterpanda63
bitterpanda63 commented Dec 30, 2025
View reviewed changes
bitterpanda63
bitterpanda63 commented Dec 30, 2025
View reviewed changes
@bitterpanda63 bitterpanda63 merged commit 9577754 into main Dec 30, 2025
38 checks passed
@bitterpanda63 bitterpanda63 deleted the add-health-check-for-sample-apps branch December 30, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hansott hansott hansott approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bitterpanda63 @hansott