-
Notifications
You must be signed in to change notification settings - Fork 47
feat: add AdyenPosMobileApi to services module #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add AdyenPosMobileApi to services module #399
Conversation
Summary of ChangesHello @yusa-opinov8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the AdyenPosMobileApi to the services module, which should resolve the issue of the posMobile property being null. The change is straightforward. However, the pull request description states that this has not been tested. It is highly recommended to add a test case that confirms the posMobile client is correctly initialized and accessible to prevent regressions. Additionally, I've left a minor comment regarding Python conventions (PEP 8) for import ordering and file endings that would improve code consistency.
Adyen/services/__init__.py
Outdated
| from .disputes import AdyenDisputesApi | ||
| from .sessionAuthentication import AdyenSessionAuthenticationApi | ||
| from .sessionAuthentication import AdyenSessionAuthenticationApi | ||
| from .posMobile import AdyenPosMobileApi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this line correctly exports the AdyenPosMobileApi, there are a couple of Python conventions that could be followed to improve code quality:
- Alphabetical Order: For better readability and maintainability, imports should be kept in alphabetical order.
posMobileshould be placed beforesessionAuthenticationin this block of imports. - File Ending: The PEP 8 style guide suggests that files should end with a single newline character. This file is currently missing it.
Please consider addressing these points for better code consistency.
|



Description
Faced an issue when the posMobile property of the Adyen object instance is null.
Proposing the fix.
Tested scenarios
Not tested
Fixed issue:
Without this fix, it is not possible to get the posMobile client.