Skip to content

Conversation

@gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Dec 12, 2025

Checkout API

  • Add support for /forward endpoint
  • In FundingSourceEnum add enum value PREPAID in ApplePayDetails, ApplePayDonations, CardDonations, and CardDetails

All models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603)

@gcatanese gcatanese requested review from a team as code owners December 12, 2025 15:30
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Checkout API by integrating the new /forward endpoint, which allows for more flexible payment processing. A major refactoring effort was also undertaken to improve data handling within various models, ensuring that nullable fields are explicitly managed during serialization and deserialization. This change provides greater control over the JSON payload and maintains data integrity.

Highlights

  • New Checkout API Endpoint: Added support for the /forward endpoint in the Checkout API, expanding its functionality.
  • Model Nullability Handling: Updated numerous models across the com.adyen.model.checkout package to explicitly handle nullable values. This was achieved by introducing isSet boolean flags for each attribute, modifying setters and builders to track when an attribute is explicitly set, and updating equals and hashCode methods to reflect these changes. A new getExplicitNulls() method with @JsonAnyGetter and an includeNullValues flag were added to control the serialization of explicitly null values.
  • Expanded Funding Source Options: The FundingSourceEnum in ApplePayDetails, ApplePayDonations, and CardDetails models now includes a PREPAID option, alongside existing CREDIT and DEBIT.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant and systematic change across numerous model classes to support explicit null values in JSON serialization. This is achieved by adding isSet flags for each property, a mechanism to control null inclusion (includeNullValues), and a @JsonAnyGetter method (getExplicitNulls) to dynamically add null-valued fields to the JSON output. The implementation appears to be correct and consistently applied, likely through code generation as indicated in the pull request description. The changes to equals() and hashCode() methods to include the new isSet flags are also correctly implemented, ensuring object equality considers whether a field was explicitly set. Additionally, the models have been updated, for example by adding the PREPAID funding source to relevant enums. Overall, the changes are well-executed and align with the goal of enhancing the API models.

@gcatanese gcatanese added the Feature Indicates a new feature addition label Dec 12, 2025
@gcatanese gcatanese requested a review from galesky-a December 16, 2025 09:11
@jeandersonbc
Copy link

Reviewed locally with @gcatanese. Changes look good to be merged.

@gcatanese gcatanese merged commit 7cdcee0 into main Dec 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Indicates a new feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants