-
Notifications
You must be signed in to change notification settings - Fork 144
Generate Checkout with /forward endpoint #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Checkout API by integrating the new Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and systematic change across numerous model classes to support explicit null values in JSON serialization. This is achieved by adding isSet flags for each property, a mechanism to control null inclusion (includeNullValues), and a @JsonAnyGetter method (getExplicitNulls) to dynamically add null-valued fields to the JSON output. The implementation appears to be correct and consistently applied, likely through code generation as indicated in the pull request description. The changes to equals() and hashCode() methods to include the new isSet flags are also correctly implemented, ensuring object equality considers whether a field was explicitly set. Additionally, the models have been updated, for example by adding the PREPAID funding source to relevant enums. Overall, the changes are well-executed and align with the goal of enhancing the API models.
|
Reviewed locally with @gcatanese. Changes look good to be merged. |
Checkout API
FundingSourceEnumadd enum valuePREPAIDinApplePayDetails,ApplePayDonations,CardDonations, andCardDetailsAll models have been updated to handle the nullable value (Mustache templates have been updated as part of #1603)