AdrianN10/EngineofDesolation #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing the code I noticed that some of the code was repeated a lot like in the classes for the Events and for some of the classes under the main subpackage. I thought the structure of the code was overall solid and good, but the parts where code was repeated was a little hard to read. The reason why I added the javadocs were so that the methods could be explained more on what they could do. I added TODO comments because I thought the suggestions would be more helpful in the flow of the code. Most of the javadocs in the Event classes were to explain what the public methods to since it can help people reading what that code does. I added TODO comments for the Event classes so some of the repeated code could be simplified later by using a helper method and for other reasons that could help with checking if the code works in other areas.