Skip to content

Conversation

@jaydenb2008
Copy link

Overall, this was a very solid project. Here are some overall improvements that could be made to the project:

  1. Fixing logic for conditionals- Whether that be using a switch statement instead of an if-else, or changing the boolean logic inside the if-else blocks, cleaning up the conditionals would make the code more cleaner and concise.
  2. Javadocing- I would've liked to see more Javadocs explaining public methods and classes. It would make the code a lot easier to understand and save a lot of time for readers.
  3. Spacing- Make sure to space out methods so they are easy to distinguish and read.
  4. Perhaps for your scene class, you could make an abstract base scene class that your other scenes can inherit to avoid writing long switch or if-else statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant