Skip to content

PM-1743. update Postmark Ruby gem to support CustomTracking #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
J0SUEFDZ wants to merge 7 commits into
base: main
Choose a base branch
from
Open

PM-1743. update Postmark Ruby gem to support CustomTracking #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ccbbfff
feature(PM-1734): adds support for custom tracking
J0SUEFDZ Jul 30, 2024
1dd6092
test(PM-1734): tests for custom tracking
J0SUEFDZ Jul 30, 2024
5fdea16
chore(PM-1734): bump versions
J0SUEFDZ Jul 30, 2024
ab01916
chore(PM-1734): rollback versions updates
J0SUEFDZ Jul 30, 2024
058d1c8
Update spec/unit/postmark/account_api_client_spec.rb
J0SUEFDZ Jul 31, 2024
bb65288
chore(PM-1734): revert newline for file
J0SUEFDZ Jul 31, 2024
280c467
Merge branch 'feature/PM-1734-custom-tracking' of https://github.com/…
J0SUEFDZ Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/postmark/account_api_client.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ def verify_domain_return_path(id)
format_response http_client.put("domains/#{id.to_i}/verifyreturnpath")
end

def verify_domain_custom_tracking(id)
format_response http_client.put("domains/#{id.to_i}/verifycustomtracking")
end

def verified_domain_spf?(id)
!!http_client.post("domains/#{id.to_i}/verifyspf")['SPFVerified']
end
Expand Down
10 changes: 10 additions & 0 deletions spec/unit/postmark/account_api_client_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,16 @@
end
end

describe '#verify_domain_custom_tracking' do
let(:response) { {"CustomTrackingVerified" => true } }

it 'performs a PUT request to /domains/:id/verifycustomtracking endpoint' do
expect(subject.http_client).to receive(:put).
with('domains/42/verifycustomtracking').and_return(response)
subject.verify_domain_custom_tracking(42)
end
end

describe '#verified_domain_spf?' do
let(:response) { {"SPFVerified" => true} }
let(:false_response) { {"SPFVerified" => false} }
Expand Down