switch to numerizer gem #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles day, month names with scalar day, year
Update README for endian_precedence option
Request to add autoload support
In addition to adding tests for the RepeaterDayPortion, the class now properly handles construction of date ranges in which the end time occurs on a day in which the time changes.
Add tests for the Day Portion Repeater…with DST fix
Replaces common time abbreviations, such as hr, min, and sec, with their full names. References: mojombo#100
Moves the suppor for time abbreviations from lib/chronic/chronic.rb to lib/chronic/repeater.rb.
Add tests for time abbreviations in test/test_parsing.rb.
Add support for common time abbreviations.
Sometimes you want to share the options Hash between multiple calls to Chronic. The existed behavior produced very confusing bugs caused by a parameter disappearing from that shared config.
Fix Chronic.parse year 00 returns nil
Use the latest Rubies on Travis
Fix warnings: `Use assert_nil if expecting nil` in MT6
Minor fixes for README.md
This allow to parse German dates without leading zeros, e.g. 1.1.2015 instead of 01.01.2015
This test covers testing sd.sm.sy without padding 0 in front of sd and sm.
Improve German date format parser
…_github_actions Migrate CI to GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Aaron,
I made this mod based on your fork in order to suppress const warnings when chronic is used in conjunction with chronic_duration (or other gems that use variants of chronic), by relying on the numerizer gem rather than including the numerizer source directly. Sending this pull request in case its something you'd want to include in your fork too.
There's one new test failure a a result of this change: it doesn't handle "tenth", which I still need to investigate, but appears to be due to some changes in the numerizer gem when comapared to the numerizer class from the original chronic implementation (failure at test/test_parsing.rb:651 : assert_equal parse_now("may 10th"), parse_now("may tenth")