Add EBLAPPD tool in EBV2 tool chain #336
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks good! New tool and no obvious problems. We have used this extensively and have not observed any problems. |
jminock
added
Ready for Level 0 Review and merge
and removed
Ready for Software meeting discussion
labels
marc1uk
reviewed
Sep 19, 2025
|
|
||
| bool EBLAPPD::Matching(int targetTrigger, int matchToTrack) | ||
| { | ||
| cout << "\033[1;34m******* EBLAPPD : Matching *******\033[0m" << endl; |
| { | ||
| uint64_t LAPPDtime = MatchBuffer_LAPPDTimestamp_ns.at(i); | ||
| // if found LAPPDtime at PairedLAPPDTimeStamps, skip //shouldn't happen | ||
| if (std::find(PairedLAPPDTimeStamps[matchToTrack].begin(), PairedLAPPDTimeStamps[matchToTrack].end(), LAPPDtime) != PairedLAPPDTimeStamps[matchToTrack].end()) |
| int matchedTrack = 0; | ||
| int matchedIndex = 0; | ||
|
|
||
| for (std::pair<int, std::vector<std::map<uint64_t, uint32_t>>> pair : GroupedTriggersInTotal) |
Collaborator
There was a problem hiding this comment.
use a reference to avoid copy
| // Log("EBLAPPD: Skipping TrackTriggerWord " + std::to_string(TrackTriggerWord), v_debug, verbosityEBLAPPD); | ||
| continue; | ||
| } | ||
| vector<std::map<uint64_t, uint32_t>> GroupedTriggers = pair.second; |
Collaborator
There was a problem hiding this comment.
use a reference to avoid copy
|
|
||
| for (int j = 0; j < GroupedTriggers.size(); j++) | ||
| { | ||
| map<uint64_t, uint32_t> groupedTrigger = GroupedTriggers.at(j); |
Collaborator
There was a problem hiding this comment.
use a reference to avoid copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EBLAPPD Tool in EventBuildingV2 tool set.
This is also splitted from PR #307