Changes to TreeMaker logic to handle new MC waveforms #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Andrew's changes, MC now has a waveform simulator that ClusterFinder handles as data-like hits. As a result we must adjust some of the logic used by downstream tools.
3 tasks
Closed
jminock
approved these changes
Aug 21, 2025
Collaborator
jminock
left a comment
jminock
left a comment
There was a problem hiding this comment.
All brackets and parentheses seem accounted for. All changes are just additional logic case which seems accounted for in all necessary places. Looks good!
Collaborator
|
Waiting for PMTWaveformSim PR |
Add option to skip execution step in case PMTWaveform has no MCHits
5 tasks
Collaborator
|
It is on hold because it needs to be merged with or after PR #358 Please see above comments |
Collaborator
|
PR #358 has been merged; so this PR is ready for merge |
Collaborator
|
seems good to me. Some of the earlier if/else branches could've been |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR is dependent on Andrew's new PMTWaveformSim tool (#324). His new tool generates waveforms from MC hits and runs the data hit finding tool (
PhaseIIADCHitFinder) over the MC waveforms. Those hits are saved in the same pulse vector as the data hits. The logic of thePhaseIITreeMakerneeded to be changed to handle data-like hits for MC events. Essentially just added some if / else statements to make sure this tool handles the MC waveform hits just like the data while keeping functionality for other MC truth information.Other downstream tools will need to be adjusted; I will open separate PRs for each of those tools.
Checklist before submitting your PR
newusage, there is a reason the data must be on the heapnewthere is adelete, unless I explicitly know why (e.g. ROOT or a BoostStore takes ownership)Additional Material
See Andrew's PR for details (#324). If you want to use the MC waveform hits, ensure the configuration for
PhaseIITreeMakerhas bothIsData 0(indicating it is MC) andPMTWaveformSim 1. Setting the latter to 0 will use the default MC hits created by summing the individual photon hits in theClusterFindertool