add item map to renderlist #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
dattanchu
approved these changes
Jul 10, 2025
| const transmissive = []; | ||
| const transparent = []; | ||
|
|
||
| let items = new WeakMap(); |
There was a problem hiding this comment.
Name something more descriptive
objectToRenderItem
Author
There was a problem hiding this comment.
renamed to objectIdToRenderItem.
Also converted from a WeakMap to a Map and used object id so it could be cleared with a stable reference.
owenmech-nl
added a commit
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Allows for a custom renderer sorting comparator to access the
RenderItemproperties of another object.Testing
Tested with https://github.com/8thwall/code8/pull/2037/files#diff-80068fa1d904387a335f350cdad391f11039e62aac3eca53fe38411a0175f022