Skip to content

Experimental erc20 fix crash when no address is provided #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ferossgp merged 1 commit into from
Dec 21, 2024
Merged

Experimental erc20 fix crash when no address is provided #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-coats-smell.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@3loop/transaction-decoder': patch
---

Fix crash in experimental erc20 resolver when address is empty. We provide an empty address when we decode logs for errors
17 changes: 13 additions & 4 deletions packages/transaction-decoder/src/abi-strategy/experimental-erc20.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import { erc20Abi, getAddress, getContract } from 'viem'

const getLocalFragments = (service: PublicClient, { address, chainId }: RequestModel.GetContractABIStrategy) =>
Effect.gen(function* () {
if (!address)
return yield* Effect.fail(new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId))

const client = yield* service
.getPublicClient(chainId)
.pipe(
Expand All @@ -13,10 +16,16 @@ const getLocalFragments = (service: PublicClient, { address, chainId }: RequestM
),
)

const inst = getContract({
abi: erc20Abi,
address: getAddress(address),
client: client.client,
const inst = yield* Effect.try({
try: () =>
getContract({
abi: erc20Abi,
address: getAddress(address),
client: client.client,
}),
catch: () => {
throw new RequestModel.ResolveStrategyABIError('local-strategy', address, chainId)
},
})

const decimals = yield* Effect.tryPromise({
Expand Down
Loading