-
Notifications
You must be signed in to change notification settings - Fork 4
Kollier feature #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kollier-martin
wants to merge
30
commits into
main
Choose a base branch
from
kollier-feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Kollier feature #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-stack/Vanquish-P2 into kollier-feature
…-stack/Vanquish-P2 into kollier-feature
…frontend and backend User, UserInfo (Optional Separate or Together) - Need to create Role class UserService and Controller classes created for understanding and implementation WebConfig for CORSFilter Data Generators and Data classes created for quick DB population
Added JWT and Jackson dependencies to pom.xml Added two classes to beans.xml Boiler plate RequestArgChecker and ServiceRequests added just in case they could be of use upon refactoring Made lists public in DataLists Deleted Email, Password, and Username Validator Tests and combined them into one Updated User to reflect UserInfo merge Combined UserInfo into User per team agreement Adding some potential methods to the UserService class Created Concert, Role, and Track classes Created Repositories to go with these new classes
Added more models Messing with Exceptions Deleted obsolete classes Messing with Repos and Configs
…ature # Conflicts: # src/main/resources/beans.xml
A few model changes Filters created but not implemented yet Created UserInfo, UserDTO, LoginCredentialsDTO classes Moved everything into 'VanquishP2' package Repos and Services optimized per model Album Controller, Repo, and Service created
Created Genre and Location Updated all existing classes to match the group standard Updated Repos, Services, and Controller to match
User and Service: Repo, Controller, Service UserRegistrationDTO pushed to match location
Added their files into my repo, refactored a little
Tested all classes and their need for JSONIgnores The only class that needs it is UserInfo as it will infinitely recurse on data retrieval Added Cascade to User and Location for UserInfo object @OnetoOne(cascade = CascadeType.REMOVE) User user; public User getUser() { return user; } public void setUser(User user) { this.user = user; } @manytoone(cascade = CascadeType.REMOVE) private Location location; public Location getLocation() { return location; } public void setLocation(Location location) { this.location = location; } // Kollier took out setLocation and setUser until we get the Front End together UserInfoController AuthFilter, CORSFilter, JWTUtil, Login, and Registration work Update UserRegistration DTO to take a city and state Changed UserRegistration to include location saving Deleted Validator, Extra Controllers, and Spare Configs DataList has been deleted and merged into DataGen Implemented Deezer Package from Team
Removed city and state logic, fixed Location logic and reimplemented it
Added getAll() for Location
Database logger is now implemented
Files Changed:
UserService
UserInfo
UserRegistrationDTO
Registration no longer takes a Location object
Added ResponseEntity returns and logic
Optimizing methods for efficient execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.