Do not use the deprecated Buffer() constructor (#285)

Refs: nodejs/citgm#605
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

Author: lpinca

lib/index.js

@@ -202,7 +202,7 @@ function OutBatch() {
 
 OutBatch.prototype.append = function (buf, flags, cb) {
   if (!Buffer.isBuffer(buf)) {
-    buf = new Buffer(String(buf), 'utf8');
+    buf = Buffer.from(String(buf), 'utf8');
   }
 
   this.content.push(buf, flags);
@@ -409,7 +409,7 @@ Object.keys(opts).forEach(function(name){
   });
 
   Socket.prototype.__defineSetter__(name, function(val) {
-    if ('string' == typeof val) val = new Buffer(val, 'utf8');
+    if ('string' == typeof val) val = Buffer.from(val, 'utf8');
     return this._zmq.setsockopt(opts[name], val);
   });
 });

test/socket.messages.js

@@ -36,7 +36,7 @@ describe('socket.messages', function(){
       push.connect('inproc://stuff_ssm');
       push.send('string');
       push.send(15.99);
-      push.send(new Buffer('buffer'));
+      push.send(Buffer.from('buffer'));
     });
   });
 
@@ -53,7 +53,7 @@ describe('socket.messages', function(){
     pull.bind('inproc://stuff_ssmm', function (error) {
       if (error) throw error;
       push.connect('inproc://stuff_ssmm');
-      push.send(['string', 15.99, new Buffer('buffer')]);
+      push.send(['string', 15.99, Buffer.from('buffer')]);
     });
   });
 
@@ -111,7 +111,7 @@ describe('socket.messages', function(){
       if (error) throw error;
       push.send('string');
       push.send(15.99);
-      push.send(new Buffer('buffer'));
+      push.send(Buffer.from('buffer'));
       pull.connect('tcp://127.0.0.1:12345');
     });
   });

test/socket.zap.js

@@ -35,10 +35,10 @@ describe('socket.zap', function(){
       return;
     }
 
-    var serverPublicKey = new Buffer('7f188e5244b02bf497b86de417515cf4d4053ce4eb977aee91a55354655ec33a', 'hex')
-      , serverPrivateKey = new Buffer('1f5d3873472f95e11f4723d858aaf0919ab1fb402cb3097742c606e61dd0d7d8', 'hex')
-      , clientPublicKey = new Buffer('ea1cc8bd7c8af65497d43fc21dbec6560c5e7b61bcfdcbd2b0dfacf0b4c38d45', 'hex')
-      , clientPrivateKey = new Buffer('83f99afacfab052406e5f421612568034e85f4c8182a1c92671e83dca669d31d', 'hex');
+    var serverPublicKey = Buffer.from('7f188e5244b02bf497b86de417515cf4d4053ce4eb977aee91a55354655ec33a', 'hex')
+      , serverPrivateKey = Buffer.from('1f5d3873472f95e11f4723d858aaf0919ab1fb402cb3097742c606e61dd0d7d8', 'hex')
+      , clientPublicKey = Buffer.from('ea1cc8bd7c8af65497d43fc21dbec6560c5e7b61bcfdcbd2b0dfacf0b4c38d45', 'hex')
+      , clientPrivateKey = Buffer.from('83f99afacfab052406e5f421612568034e85f4c8182a1c92671e83dca669d31d', 'hex');
 
     rep.on('message', function(msg){
       msg.should.be.an.instanceof(Buffer);

test/zap.js

@@ -24,20 +24,20 @@ module.exports.start = function(count) {
     var zapReq = {
       version: data.shift(),
       requestId: data.shift(),
-      domain: new Buffer(data.shift()).toString('utf8'),
-      address: new Buffer(data.shift()).toString('utf8'),
-      identity: new Buffer(data.shift()).toString('utf8'),
-      mechanism: new Buffer(data.shift()).toString('utf8'),
+      domain: Buffer.from(data.shift()).toString('utf8'),
+      address: Buffer.from(data.shift()).toString('utf8'),
+      identity: Buffer.from(data.shift()).toString('utf8'),
+      mechanism: Buffer.from(data.shift()).toString('utf8'),
       credentials: data.slice(0)
     };
 
     zap.send(returnPath.concat([
       zapReq.version,
       zapReq.requestId,
-      new Buffer("200", "utf8"),
-      new Buffer("OK", "utf8"),
-      new Buffer(0),
-      new Buffer(0)
+      Buffer.from("200", "utf8"),
+      Buffer.from("OK", "utf8"),
+      Buffer.alloc(0),
+      Buffer.alloc(0)
     ]));
   });