test: better handling of process error and timeout for context exits

Author: aminya

test/unit/context-process-exit-test.ts

@@ -30,16 +30,16 @@ describe("context process exit", function () {
 
     it("should not occur when sockets are open and polling", async function () {
       this.slow(1000)
-      const {code, is_timeout} = await createProcess(() => {
+      const {code, isTimeout} = await createProcess(() => {
         const socket1 = new zmq.Dealer()
         socket1.connect("inproc://foo")
         socket1.receive().catch(err => {
           throw err
         })
       })
 
+      assert.equal(isTimeout, true)
       assert.equal(code, -1)
-      assert.equal(is_timeout, true)
     })
 
     it("should produce warning when messages are queued with blocky", async function () {
@@ -143,15 +143,15 @@ describe("context process exit", function () {
 
     it("should not occur when sockets are open and polling", async function () {
       this.slow(1000)
-      const {code, is_timeout} = await createProcess(() => {
+      const {code, isTimeout} = await createProcess(() => {
         const context = new zmq.Context()
         const socket1 = new zmq.Dealer({context})
         socket1.connect("inproc://foo")
         socket1.receive()
       })
 
+      assert.equal(isTimeout, true)
       assert.equal(code, -1)
-      assert.equal(is_timeout, true)
     })
   })
 })

test/unit/helpers.ts

@@ -148,7 +148,7 @@ interface Result {
   code: number
   stdout: Buffer
   stderr: Buffer
-  is_timeout: boolean
+  isTimeout: boolean
 }
 
 export function createProcess(fn: () => void): Promise<Result> {
@@ -158,7 +158,13 @@ export function createProcess(fn: () => void): Promise<Result> {
     const result = fn()
     if (result instanceof Promise) {
       result.catch(err => {
-        throw err
+        if (error instanceof Error) {
+          console.error(error.message)
+          console.error(error.stack)
+        } else {
+          console.error(error)
+        }
+        process.exit(10)
       })
     }
   `
@@ -191,12 +197,12 @@ export function createProcess(fn: () => void): Promise<Result> {
           )
         }
 
-        resolve({code, stdout, stderr, is_timeout: false})
+        resolve({code, stdout, stderr, isTimeout: false})
       }
     })
 
     setTimeout(() => {
-      resolve({code: -1, stdout, stderr, is_timeout: true})
+      resolve({code: -1, stdout, stderr, isTimeout: true})
       console.error(
         `Child timed out\n${stdout.toString()}\n${stderr.toString()}`,
       )