Socket::PollForEvents: Don't throw a C++ exception

n-riesco · n-riesco · commit ad59b30e5b22 · 2016-11-26T14:42:27.000Z
diff --git a/binding.cc b/binding.cc
@@ -374,8 +374,10 @@ namespace zmq {
       if (rc < 0) {
         if (zmq_errno()==EINTR) {
           continue;
+        } else {
+          Nan::ThrowError(ErrorMessage());
+          return -1;
         }
-        throw std::runtime_error(ErrorMessage());
       } else {
         break;
       }

Original file line number	Diff line number	Diff line change
`@@ -374,8 +374,10 @@ namespace zmq {`
`374`	`374`	`if (rc < 0) {`
`375`	`375`	`if (zmq_errno()==EINTR) {`
`376`	`376`	`continue;`
	`377`	`+ } else {`
	`378`	`+ Nan::ThrowError(ErrorMessage());`
	`379`	`+ return -1;`
`377`	`380`	`}`
`378`		`- throw std::runtime_error(ErrorMessage());`
`379`	`381`	`} else {`
`380`	`382`	`break;`
`381`	`383`	`}`