Skip to content

Commit 99712aa

Browse files
Skip GC tests in Node 13 due to bug NAPI.
1 parent bc8d2af commit 99712aa

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

.travis.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ jobs:
4848
# Test recent Node versions.
4949
- os: linux
5050
node_js: "12"
51-
env: ZMQ_DRAFT=true INCLUDE_COMPAT_TESTS=true
51+
# Skip GC tests due to https://github.com/node-ffi-napi/weak-napi/issues/16
52+
env: ZMQ_DRAFT=true SKIP_GC_TESTS=true INCLUDE_COMPAT_TESTS=true
5253

5354
- os: linux
5455
node_js: "13"
55-
env: ZMQ_DRAFT=true
56+
# Skip GC tests due to https://github.com/node-ffi-napi/weak-napi/issues/16
57+
env: ZMQ_DRAFT=true SKIP_GC_TESTS=true
5658

5759
## PREBUILD STAGE
5860

test/unit/socket-close-test.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
9797
})
9898

9999
it("should release reference to context", async function() {
100+
if (process.env.SKIP_GC_TESTS) this.skip()
100101
this.slow(200)
101102

102103
const weak = require("weak-napi")
@@ -124,6 +125,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
124125

125126
describe("in gc finalizer", function() {
126127
it("should release reference to context", async function() {
128+
if (process.env.SKIP_GC_TESTS) this.skip()
127129
this.slow(200)
128130

129131
const weak = require("weak-napi")

test/unit/socket-send-receive-test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
7878
})
7979

8080
it("should copy and release small buffers", async function() {
81+
if (process.env.SKIP_GC_TESTS) this.skip()
8182
const weak = require("weak-napi")
8283

8384
let released = false
@@ -95,6 +96,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
9596
})
9697

9798
it("should retain large buffers", async function() {
99+
if (process.env.SKIP_GC_TESTS) this.skip()
98100
const weak = require("weak-napi")
99101

100102
let released = false
@@ -285,6 +287,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
285287
})
286288

287289
it("should release buffers", async function() {
290+
if (process.env.SKIP_GC_TESTS) this.skip()
288291
const weak = require("weak-napi")
289292

290293
const n = 10
@@ -320,6 +323,7 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
320323
})
321324

322325
it("should release buffers after echo", async function() {
326+
if (process.env.SKIP_GC_TESTS) this.skip()
323327
const weak = require("weak-napi")
324328

325329
const n = 10

0 commit comments

Comments
 (0)