Fixes for older ZMQ versions.

Author: rolftimmermans

src/observer.cc

@@ -276,11 +276,10 @@ void Observer::Receive(const Napi::Promise::Deferred& res) {
     case ZMQ_EVENT_ACCEPT_FAILED:
     case ZMQ_EVENT_CLOSE_FAILED:
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_NO_DETAIL
-    case ZMQ_EVENT_HANDSHAKE_FAILED_NO_DETAIL: {
+    case ZMQ_EVENT_HANDSHAKE_FAILED_NO_DETAIL:
+#endif
         event["error"] = ErrnoException(Env(), value).Value();
         break;
-    }
-#endif
 
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_PROTOCOL
     case ZMQ_EVENT_HANDSHAKE_FAILED_PROTOCOL: {
@@ -291,10 +290,9 @@ void Observer::Receive(const Napi::Promise::Deferred& res) {
 #endif
 
 #ifdef ZMQ_EVENT_HANDSHAKE_FAILED_AUTH
-    case ZMQ_EVENT_HANDSHAKE_FAILED_AUTH: {
+    case ZMQ_EVENT_HANDSHAKE_FAILED_AUTH:
         event["error"] = StatusException(Env(), AuthError(value), value).Value();
         break;
-    }
 #endif
 
     case ZMQ_EVENT_MONITOR_STOPPED: {

test/unit/helpers.ts

@@ -6,8 +6,11 @@ import {Worker} from "worker_threads"
 
 import * as zmq from "../../src"
 
-/* Stop pending messages in test suite from preventing process exit. */
-zmq.context.blocky = false
+console.log(`ZeroMQ version ${zmq.version}`)
+if (semver.satisfies(zmq.version, ">= 4.2")) {
+  /* Stop pending messages in test suite from preventing process exit. */
+  zmq.context.blocky = false
+}
 
 /* Windows cannot bind on a ports just above 1014; start higher to be safe. */
 let seq = 5000

test/unit/socket-xpub-xsub-test.ts

@@ -1,3 +1,4 @@
+import * as semver from "semver"
 import * as zmq from "../../src"
 
 import {assert} from "chai"
@@ -223,6 +224,9 @@ for (const proto of testProtos("tcp", "ipc", "inproc")) {
       })
 
       it("should forward all subscriptions/unsubscriptions", async function() {
+        /* ZMQ 4.2 first introduced ZMQ_XPUB_VERBOSER. */
+        if (semver.satisfies(zmq.version, "< 4.2")) this.skip()
+
         const address = uniqAddress(proto)
 
         const subs: Buffer[] = []