Skip to content

Commit 15c3562

Browse files
committed
Integrate review comments.
Change gnu++17 to c++17. Update to latest v21 Electron release
1 parent 9f2d372 commit 15c3562

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

binding.gyp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
'xcode_settings': {
4848
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES',
4949
'MACOSX_DEPLOYMENT_TARGET': '10.15',
50-
'CLANG_CXX_LANGUAGE_STANDARD': 'gnu++17',
50+
'CLANG_CXX_LANGUAGE_STANDARD': 'c++17',
5151
},
5252
'libraries': ['<(PRODUCT_DIR)/../../zmq/lib/libzmq.a'],
5353
'include_dirs': ['<(PRODUCT_DIR)/../../zmq/include'],
@@ -57,7 +57,7 @@
5757
['OS=="linux"', {
5858
'libraries': ['<(PRODUCT_DIR)/../../zmq/lib/libzmq.a'],
5959
'include_dirs': ['<(PRODUCT_DIR)/../../zmq/include'],
60-
'cflags_cc': [ '-std=gnu++17' ],
60+
'cflags_cc': [ '-std=c++17' ],
6161
}],
6262
],
6363
}],

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"scripts": {
2828
"install": "node-gyp-build || npm run build:libzmq",
2929
"build:libzmq": "node-gyp rebuild",
30-
"prebuildify": "prebuildify -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t electron@11.5.0 -t electron@21.0.1 --strip",
31-
"prebuildify-ia32": "prebuildify --arch=ia32 -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t electron@11.5.0 -t electron@21.0.1 --strip",
30+
"prebuildify": "prebuildify -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t electron@11.5.0 -t electron@21.2.3 --strip",
31+
"prebuildify-ia32": "prebuildify --arch=ia32 -t 18.12.1 -t 16.18.1 -t 14.21.1 -t 12.22.12 -t electron@11.5.0 -t electron@21.2.3 --strip",
3232
"build:docs": "jsdoc -R README.md -d docs lib/*.js",
3333
"test": "mocha --expose-gc --slow 300",
3434
"test:electron": "electron-mocha --slow 300",

0 commit comments

Comments
 (0)