[Backport v4.3-branch] sys: getopt: Rename getopt to sys_getopt to avoid conflicts with Posix #100598
+538
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As Zephyr getopt is not really compatible with Posix getopt, rename Zephyr getopt to sys_getopt. Background: Zephyr getopt module was introduced in zephyrproject-rtos#31356 to be used by the shell. Zephyr's getopt is not the standard one. It has multiple APIs which make it more suited for a system like Zephyr where different components may want to use it for different purposes. Including APIs to init it, get and set its internal state etc. Several Zephyr modules (shell, net, wifi, ztest) use this getopt with these special APIs. The getopt module is bundled in the POSIX compatibility API subsystem (CONFIG_POSIX_C_LIB_EXT). Problem description: As it is not the standard getopt(), no C library can possibly provide a Zephyr compatible version (even if such C library were to provide a standard getopt()). As it is bundled in Zephyr's POSIX API in CONFIG_POSIX_C_LIB_EXT), multiple components that depend on it are selecting CONFIG_POSIX_C_LIB_EXT. Zephyr core components should not depend on the POSIX API in this way. Changes done in this commit: Rename the getopt*() APIs to sys_getopt*() and move them into a module under lib/utils with its own Kconfig option to enable it. Zephyr's users are changed to use this new component. The POSIX subsystem can continue providing getopt() by calling the new sys_getopt() and in that way retain backwards compatibility for external users. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no> (cherry picked from commit 22f9ef0)
Allow user to use the new sys_getopt API via the old non-Posix compliant getopt API. This is a temporary solution and the shim will be deprecated and eventually removed at some point. Signed-off-by: Jukka Rissanen <jukka.rissanen@nordicsemi.no> (cherry picked from commit d164f8b)
mmahadevan108
added
area: Networking
Backport
zephyrbot
requested review from
andyross,
avisconti,
carlescufi,
cfriedt,
dcpleung,
erwango,
jakub-uC,
jfischer-no,
jukkar,
kartben,
nashif,
peter-mitsis,
rlubos,
thenguyenyf and
ycsin
mmahadevan108
requested review from
fabiobaltieri
and removed request for
thenguyenyf
peter-mitsis
approved these changes
Dec 5, 2025
Member
|
@mmahadevan108 why the backport, the getopt renaming is not really a bug fix? |
Contributor
|
@mmahadevan108 The linked issue in the description should be a bug issue, not the backport failure one. |
|
Contributor
Author
This was identified as an issue by our team developing Matter applications. Without this fix, building Matter applications fails due to macro redefinition errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport d164f8b~2..d164f8b from #98845